[oe] [meta-oe][PATCH] librsync: new package

[Stefano Babic]

Hi Bartosz,

On 09/12/19 15:56, Bartosz Golaszewski wrote:
> pon., 9 gru 2019 o 15:53 Stefano Babic <sbabic at denx.de> napisał(a):
>>
>> Hi Bartosz,
>>
>> On 09/12/19 15:46, Bartosz Golaszewski wrote:
>>> From: Bartosz Golaszewski <bgolaszewski at baylibre.com>
>>>
>>> rdiff is a popular tool for calculating binary delta patches. It's
>>> provided by the librsync package (unrelated to rsync already available
>>> in poky).
>>>
>>
>> Nice, I added it (really, 2.1) to my public layer, but this definetely
>> belongs to OE:
>>
>> https://github.com/sbabic/meta-swupdate/blob/master/recipes-support/librsync/librsync_2.1.0.bb
>>
> 
> Ha! Somehow it didn't pop up in google search. If you want you can
> send your own patch instead of this one.

I am fine with yours, too ;-)

> 
> We probably have the same idea for updates - I'm using it in my
> binary-delta update module for mender.

Exactly the same idea: I am using it for binary-delta update in SWUpdate ;-)

> 
>>
>>> This recipe adds new packages for librsync and rdiff.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bgolaszewski at baylibre.com>
>>> ---
>>>  .../recipes-support/librsync/librsync_2.2.1.bb | 18 ++++++++++++++++++
>>>  1 file changed, 18 insertions(+)
>>>  create mode 100644 meta-oe/recipes-support/librsync/librsync_2.2.1.bb
>>>
>>> diff --git a/meta-oe/recipes-support/librsync/librsync_2.2.1.bb b/meta-oe/recipes-support/librsync/librsync_2.2.1.bb
>>> new file mode 100644
>>> index 000000000..9d224767c
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-support/librsync/librsync_2.2.1.bb
>>> @@ -0,0 +1,18 @@
>>> +SUMMARY = "Remote delta-compression library."
>>> +AUTHOR = "Martin Pool, Andrew Tridgell, Donovan Baarda, Adam Schubert"
>>> +
>>> +LICENSE = "LGPLv2.1+"
>>> +LIC_FILES_CHKSUM = "file://COPYING;md5=d8045f3b8f929c1cb29a1e3fd737b499"
>>> +
>>> +SRC_URI = "git://github.com/librsync/librsync.git"
>>> +SRCREV = "5917692418657dc78c9cbde3a8db4c85f25b9c8d"
>>> +S = "${WORKDIR}/git"
>>> +
>>> +DEPENDS = "popt"
>>
>> Don't you have any depends from zlib / bzip ? cmake tests it, if you do
>> not add it, build will be fine but without support.
>>
> 
> Sure - it probably should become a PACKAGECONFIG option.

Well, anyway the library without compression support loses most of its
meaning... But a PACKAGECONFIG with default as on for both compression
libraries is fine.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================