[oe] [meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory

Burton, Ross ross.burton at intel.com
Mon Feb 25 17:03:32 UTC 2019


The original patch doesn't explain what it's doing and is clearly
going to remove executable bits from directories, which clearly isn't
right.

I'd say remove it, and *then* if it breaks again fix properly.

Ross

On Mon, 25 Feb 2019 at 15:07, Khem Raj <raj.khem at gmail.com> wrote:
>
> On Mon, Feb 25, 2019 at 6:00 AM Otavio Salvador <otavio at ossystems.com.br> wrote:
> >
> > The chmod was removing the executing bit from the directory and then
> > the native version was failing to build.
> >
> > Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> > ---
> >
> >  meta-python/recipes-devtools/python/python-idna.inc | 4 ----
> >  1 file changed, 4 deletions(-)
> >
> > diff --git a/meta-python/recipes-devtools/python/python-idna.inc b/meta-python/recipes-devtools/python/python-idna.inc
> > index 436b58606..519812ddc 100644
> > --- a/meta-python/recipes-devtools/python/python-idna.inc
> > +++ b/meta-python/recipes-devtools/python/python-idna.inc
> > @@ -16,7 +16,3 @@ do_compile_prepend() {
> >  }
> >
> >  BBCLASSEXTEND = "native nativesdk"
> > -
> > -do_install_append() {
> > -    chmod 664 -R ${D}${PYTHON_SITEPACKAGES_DIR}/*.egg-info/
> > -}
>
> this overturns a prior fix
> https://git.openembedded.org/meta-openembedded/commit/?id=79bb01985260800f80b393e73b387543f86f9e62
>
> I think it would be better to resolve the original issue before reverting
> it or maybe just appy this for target recipe alone
>
> > \ No newline at end of file
> > --
> > 2.20.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


More information about the Openembedded-devel mailing list