[oe] [meta-oe][PATCH 1/4] meta-oe: fixup LAYERDEPENDS to include meta-python

Martin Jansa martin.jansa at gmail.com
Thu Feb 28 17:59:03 UTC 2019


Yes, please revert.

Having circular dependency between meta-oe and meta-python is worse than:

cp -ra meta-python/* meta-oe/ && rmdir meta-python

that's why was such patch rejected few times already, e.g. in
https://www.mail-archive.com/openembedded-devel@lists.openembedded.org/msg61053.html

before it was protobuf, now mongodb

Is it just python-typing and python-cheetah meta-oe (mongodb) needs from
meta-python?

Why not move these 2 to meta-oe/recipes-devtools/python/ to make
yocto-check-layer script happy for next 3 months before someone sends
another patch like this.

Or we should gave up and copy all layers to oe-core repository and call it
oe-classic-ng :).

BTW: Yes I understand that the issue this patch was trying to fix was valid
and yocto-check-layer is useful in some cases (e.g. this issue isn't seen
by many people because almost everybody needs something from meta-python as
well, so it's almost always included and inter-layer dependency like this
can easily slip-in unnoticed. But if we start making dependencies between
layers willy-nilly, then we will just end-up with one huge pile of recipes
disadvantageously separated in multiple layers/repositories, but without
any separation.

Regards,


On Thu, Feb 28, 2019 at 6:35 PM Khem Raj <raj.khem at gmail.com> wrote:

> On Tue, Feb 26, 2019 at 10:14 AM Khem Raj <raj.khem at gmail.com> wrote:
> >
> > On Tue, Feb 26, 2019 at 9:39 AM Peter Kjellerstedt
> > <peter.kjellerstedt at axis.com> wrote:
> > >
> > > > -----Original Message-----
> > > > From: openembedded-devel-bounces at lists.openembedded.org
> <openembedded-
> > > > devel-bounces at lists.openembedded.org> On Behalf Of Khem Raj
> > > > Sent: den 22 februari 2019 19:19
> > > > To: Nicolas Dechesne <nicolas.dechesne at linaro.org>
> > > > Cc: openembeded-devel <openembedded-devel at lists.openembedded.org>
> > > > Subject: Re: [oe] [meta-oe][PATCH 1/4] meta-oe: fixup LAYERDEPENDS to
> > > > include meta-python
> > > >
> > > > On Fri, Feb 22, 2019 at 9:30 AM Nicolas Dechesne
> > > > <nicolas.dechesne at linaro.org> wrote:
> > > > >
> > > > > meta-oe depends on meta-python, for mongodb recipe, since
> > > > > 5cf9a144ad16 (mongodb: Upgrade to 4.0.1 release)
> > > > >
> > > >
> > > > The dependency was always there, but I wonder if there is a better
> > > > place for mongodb than meta-oe
> > >
> > > Can we please revert this? Making meta-oe depend on meta-python
> > > is not the right thing to do. Either move mongodb to another layer
> > > that already depends on meta-python or where it is fine to do so,
> > > or move python-cheetah to meta-oe. The latter seems like the easier
> > > choice.
> >
> > I am fine with dropping mongodb from meta-oe and revert this patch
> > and the problem I see is that now meta-oe depends on meta-python
> > and meta-python depends on meta-oe, which is not good. Although
> > having meta-python as a dependency for meta-oe is fine or vice-versa
> > but no loops.
> >
>
> I think we have to revert it for now. Its breaking bitbake add-layers
> due to circular dependency.
>
> > >
> > > //Peter
> > >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>


More information about the Openembedded-devel mailing list