[oe] [meta-oe][PATCH] pmdk: fix install error

[Randy MacLeod]

On 1/9/19 1:18 PM, Khem Raj wrote:
> On Wed, Jan 9, 2019 at 2:17 AM Liu, Yongxin <Yongxin.Liu at windriver.com> wrote:
>>
>>> -----Original Message-----
>>> From: Khem Raj [mailto:raj.khem at gmail.com]
>>> Sent: Wednesday, January 9, 2019 18:06
>>> To: Liu, Yongxin
>>> Cc: openembeded-devel
>>> Subject: Re: [oe] [meta-oe][PATCH] pmdk: fix install error
>>>
>>> On Tue, Jan 8, 2019 at 10:20 PM Yongxin Liu <yongxin.liu at windriver.com>
>>> wrote:
>>>>
>>>> .so files are not generated in usr/local/lib/ but in usr/local/lib64.
>>>>
>>>> Signed-off-by: Yongxin Liu <yongxin.liu at windriver.com>
>>>> ---
>>>>   meta-oe/recipes-extended/pmdk/pmdk_1.4.2.bb | 4 ++--
>>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/meta-oe/recipes-extended/pmdk/pmdk_1.4.2.bb b/meta-
>>> oe/recipes-extended/pmdk/pmdk_1.4.2.bb
>>>> index 3da22a970..af2229f1c 100644
>>>> --- a/meta-oe/recipes-extended/pmdk/pmdk_1.4.2.bb
>>>> +++ b/meta-oe/recipes-extended/pmdk/pmdk_1.4.2.bb
>>>> @@ -43,10 +43,10 @@ do_install() {
>>>>          mv ${D}/usr/local/bin/daxio ${D}${bindir}/
>>>>
>>>>          install -d ${D}${libdir}
>>>> -       mv ${D}/usr/local/lib/*so* ${D}${libdir}/
>>>> +       mv ${D}/usr/local/lib64/*so* ${D}${libdir}/
>>>>
>>>
>>> I wonder if this should be using /usr/local/${base_libdir} here
>>
>> Since ${base_libdir} is "/lib64", should we use "/usr/local${base_libdir}" ?
>> Or it is fine to go with "/usr/local//lib64" after parsing?
> 
> using /usr/local${base_libdir} is fine

It's a little odd that the default prefix is /usr/local rather
than /usr . It would make sense to start with /usr/local in
early development but the first commit to pmdk on github was
in 2014...

If this is part of the system, use /usr, if it's a hack or
an install owned by the local system admin, use /usr/local.
As per, for example:
   https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s09.html

../Randy

> 
>>
>>
>> Thanks,
>> Yongxin
>>
>>>>          install -d ${D}${libdir}/pkgconfig
>>>> -       mv ${D}/usr/local/lib/pkgconfig/*.pc ${D}${libdir}/pkgconfig/
>>>> +       mv ${D}/usr/local/lib64/pkgconfig/*.pc ${D}${libdir}/pkgconfig/
>>>>
>>>>          install -d ${D}${includedir}
>>>>          mv ${D}/usr/local/include/* ${D}${includedir}/
>>>> --
>>>> 2.14.4
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-devel mailing list
>>>> Openembedded-devel at lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


-- 
# Randy MacLeod
# Wind River Linux