[oe] [PATCH 2/6] [meta-gnome] wv: Don't use ${PN}

Andreas Müller schnitzeltony at gmail.com
Fri Jan 11 00:59:24 UTC 2019


On Thu, Jan 10, 2019 at 10:42 AM Richard Weinberger <richard at nod.at> wrote:
>
> Don't use ${PN} for the source dir, it will break multilib builds.
> The correct variable is ${BPN}.
>
> The bitbake defaults are:
> BP = "${BPN}-${PV}"
> S = "${WORKDIR}/${BP}"
>
> Therefore we can remove this line.
>
> Cc: Andreas Müller <schnitzeltony at googlemail.com>
> Signed-off-by: Richard Weinberger <richard at nod.at>
> ---
>  meta-gnome/recipes-gnome/wv/wv_1.2.4.bb | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/meta-gnome/recipes-gnome/wv/wv_1.2.4.bb b/meta-gnome/recipes-gnome/wv/wv_1.2.4.bb
> index 8ed1fcd15ca8..03ee5b4ac4aa 100644
> --- a/meta-gnome/recipes-gnome/wv/wv_1.2.4.bb
> +++ b/meta-gnome/recipes-gnome/wv/wv_1.2.4.bb
> @@ -16,6 +16,4 @@ SRC_URI[sha256sum] = "673109910e22d4cf94cc8be4dcb9a0c41b5fbdb1736d4b7bdc7778894d
>
>  inherit autotools pkgconfig
>
> -S = "${WORKDIR}/${PN}-${PV}"
> -
>  EXTRA_OECONF = ""
> --
> 2.20.1
>
>From a quick glance these patches look good to me - should invest more
on multilib tests...

Andreas


More information about the Openembedded-devel mailing list