[oe] [PATCH 2/5] networkmanager: introduce polkit package config

[Andreas Müller]

On Thu, Jan 17, 2019 at 5:27 PM Stefan Agner <stefan at agner.ch> wrote:
Hi Stefan,

sorry but don't like this patch as is:
>
> From: Stefan Agner <stefan.agner at toradex.com>
>
> Currently polkit is enabled if systemd is in package config. Those
> two things are orthogonal: NetworkManager can be used with systemd
> and without polkit just fine.
Did you test this (=change networkmanager connections settings) as an
unpriviledged user?
>
> Introduce a new polkit package config and enable it depending on
> whether polkit is in DISTRO_FEATURES.

* it changes the current behaviour and the default suggested by
configure.ac: 'we usually compile with polkit support.' and
meson.build sets polkit by default.
* as far as I know there is no polkit DISTRO_FEATURE in metaverse yet.

I suggest to add polkit PACKAGECONFIG if systemd is in DISTRO_FEATURES
- if you don't want polkit you can add a PACKAGECONFIG_remove =
"polkit" somewhere.

Andreas