[oe] [PATCH 3/5] xfce4-power-manager: enable polkit depending on distro feature

[Randy MacLeod]

On 1/17/19 1:39 PM, Stefan Agner wrote:
> On 17.01.2019 18:53, Andreas Müller wrote:
>> On Thu, Jan 17, 2019 at 5:27 PM Stefan Agner <stefan at agner.ch> wrote:
>>>
>>> From: Stefan Agner <stefan.agner at toradex.com>
>>>
>>> systemd and polkit are not directly related. It is just fine to build
>>> with systemd but without polkit.
>> Surely it builds but is it still usable as unpriviledged user?
> 
> TBH, I don't know, did not run XFCE.

We do! :)

> 
> If it is unusable, we probably should not make it an option anyway? Just
> enable it always and make polkit a fixed dependency?

Grace,
Please apply this series of patches and check if
xfce4-power-manager is usable as an unprivileged user?

../Randy

> 
> --
> Stefan
> 
>>
>> Andreas
>>> Rename the systemd package config
>>> to polkit and enable it depending on whether polkit is enabled in
>>> DISTRO_FEATURES.
>>>
>>> Signed-off-by: Stefan Agner <stefan.agner at toradex.com>
>>> ---
>>>   .../recipes-xfce/xfce4-power-manager/xfce4-power-manager_1.6.1.bb     | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/meta-xfce/recipes-xfce/xfce4-power-manager/xfce4-power-manager_1.6.1.bb b/meta-xfce/recipes-xfce/xfce4-power-manager/xfce4-power-manager_1.6.1.bb
>>> index ed117b0a6..1cdcb4160 100644
>>> --- a/meta-xfce/recipes-xfce/xfce4-power-manager/xfce4-power-manager_1.6.1.bb
>>> +++ b/meta-xfce/recipes-xfce/xfce4-power-manager/xfce4-power-manager_1.6.1.bb
>>> @@ -20,8 +20,8 @@ EXTRA_OECONF = " \
>>>       --enable-panel-plugins \
>>>   "
>>>
>>> -PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"
>>> -PACKAGECONFIG[systemd] = "--enable-polkit, --disable-polkit, polkit"
>>> +PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'polkit', d)}"
>>> +PACKAGECONFIG[polkit] = "--enable-polkit, --disable-polkit, polkit"
>>>
>>>   PACKAGES += "xfce4-powermanager-plugin"
>>>
>>> --
>>> 2.13.6
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel at lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


-- 
# Randy MacLeod
# Wind River Linux