[oe] [PATCH] libvncserver: Update to latest commit post 0.9.12

Randy MacLeod randy.macleod at windriver.com
Thu Jan 24 04:27:48 UTC 2019


On 1/23/19 10:58 PM, Randy MacLeod wrote:
> Update to latest git HEAD which includes a fix for CVE-2018-15127.
> 
> Support for lzo in addition to a bundled minilzo was added so
> add a PACKAGECONFIG[lzo] and add it to the default config.
> 
> Signed-off-by: Randy MacLeod <Randy.MacLeod at windriver.com>
> ---
>   meta-oe/recipes-graphics/libvncserver/libvncserver_git.bb | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-oe/recipes-graphics/libvncserver/libvncserver_git.bb b/meta-oe/recipes-graphics/libvncserver/libvncserver_git.bb
> index 25917756f..b789055bb 100644
> --- a/meta-oe/recipes-graphics/libvncserver/libvncserver_git.bb
> +++ b/meta-oe/recipes-graphics/libvncserver/libvncserver_git.bb
> @@ -5,10 +5,11 @@ PRIORITY = "optional"
>   LICENSE = "GPLv2"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=361b6b837cad26c6900a926b62aada5f"
>   
> -PACKAGECONFIG ??= "gcrypt gnutls jpeg png ${@bb.utils.contains('DISTRO_FEATURES','systemd','systemd','',d)} sdl zlib"
> +PACKAGECONFIG ??= "gcrypt gnutls jpeg png lzo ${@bb.utils.contains('DISTRO_FEATURES','systemd','systemd','',d)} sdl zlib"
>   PACKAGECONFIG[gcrypt] = ",,libgcrypt,libgcrypt"
>   PACKAGECONFIG[gnutls] = ",,gnutls"
>   PACKAGECONFIG[jpeg] = ",-DWITH_JPEG=OFF,jpeg"
> +PACKAGECONFIG[lzo] = ",,lzo"
>   PACKAGECONFIG[openssl] = ",,openssl"
>   PACKAGECONFIG[png] = ",-DWITH_PNG=OFF,libpng,libpng"
>   PACKAGECONFIG[systemd] = ",,systemd"
> @@ -18,6 +19,6 @@ PACKAGECONFIG[zlib] = ",,zlib"
>   inherit cmake
>   
>   SRC_URI = "git://github.com/LibVNC/libvncserver"
> -SRCREV = "f997b5a75fa171d79c5e568b7157fba83c8d8355"
> +SRCREV = "c0a23857a5c42b45b6d22ccf7218becd1fa69402"
>   
>   S = "${WORKDIR}/git"
> 

glibc builds are fine,
musl builds are underway.


There are some packaging warnings that I haven't fixed.

It would seem to me that the .so files should be separated
into:
libvncserver
libvncclient
along with a single -dev/dgb package just like debian does:

$ apt show libvnc<TAB>
libvncclient1        libvncclient1-dbg    libvncserver1 
libvncserver1-dbg    libvncserver-config  libvncserver-dev

I'm not sure what's in the -config package yet.

I'll make these packaging changes in another commit in a few days
unless someone objects or beats me to it.

-- 
# Randy MacLeod
# Wind River Linux


More information about the Openembedded-devel mailing list