[oe] [PATCH 3/5] xfce4-power-manager: enable polkit depending on distro feature

[Stefan Agner]

On 23.01.2019 04:02, Yu, Mingli wrote:
> On 2019年01月21日 02:07, Khem Raj wrote:
>> On Thu, Jan 17, 2019 at 4:30 PM Randy MacLeod
>> <randy.macleod at windriver.com> wrote:
>>>
>>> On 1/17/19 1:39 PM, Stefan Agner wrote:
>>>> On 17.01.2019 18:53, Andreas Müller wrote:
>>>>> On Thu, Jan 17, 2019 at 5:27 PM Stefan Agner <stefan at agner.ch> wrote:
>>>>>>
>>>>>> From: Stefan Agner <stefan.agner at toradex.com>
>>>>>>
>>>>>> systemd and polkit are not directly related. It is just fine to build
>>>>>> with systemd but without polkit.
>>>>> Surely it builds but is it still usable as unpriviledged user?
>>>>
>>>> TBH, I don't know, did not run XFCE.
>>>
>>> We do! :)
>>>
>>>>
>>>> If it is unusable, we probably should not make it an option anyway? Just
>>>> enable it always and make polkit a fixed dependency?
>>>
>>> Grace,
>>> Please apply this series of patches and check if
>>> xfce4-power-manager is usable as an unprivileged user?
>>
>> Thanks for testing it out, I will wait to hear from you
> 
> Hi Randy and Khem:
> 
> It's usable as an unprivileged user when project configured with below
> items altogether:
> 1, with systemd DISTRO_FEATURES
> 2, without polkit DISTRO_FEATURES
> 3, polkit package installed.
> BTW, if we don't install polkit, there comes below error:
> Missing or unbuildable dependency chain was:
> ['packagegroup-xfce-base', 'xfce4-session', 'polkit']

I don't understand this. In this case, you have polkit *not* in
DISTRO_FEATURES and this patch applied?

In that case, packageconfig polkit should not be enabled, and hence
polkit should not be a dependency.


> 
> And there also comes a question about
> "[oe] [PATCH 1/5] polkit: add polkit as a required distro feature" as
> there is a logic as REQUIRED_DISTRO_FEATURES = "polkit" added, but why
> does it inherit distro_features_check?

polkit does not inherit distro_features_check, but should I guess?

You probably meant to ask "why does it *not* inherit
distro_features_check?"

Good catch, will send a patch to add distro_features_check.

--
Stefan