[oe] [meta-oe][PATCH 1/2] libkcapi: Fix missing bash (for apps) and unneeded checksums (for testapp) when building

[Khem Raj]

Another approach could be remove bashism from the shell script which is
demanding it and ask for simple bin/sh

On Fri, Jan 25, 2019 at 8:14 AM Krzysztof Kozlowski <krzk at kernel.org> wrote:

> Fix build failures:
> 1. with "apps" PACKAGECONFIG:
>
>     ERROR: libkcapi-1.1.3+gitAUTOINC+1c736c43eb-r0 do_package:
>     QA Issue: libkcapi: Files/directories were installed but not shipped
> in any package:
>       /usr/bin/.sha1hmac.hmac
>       /usr/lib/.libkcapi.so.1.1.3.hmac
>
> 2. with "testapp" PACKAGECONFIG:
>
>     ERROR: libkcapi-1.1.3+gitAUTOINC+1c736c43eb-r0 do_package_qa:
>     QA Issue: /usr/libexec/libkcapi/test.sh contained in package libkcapi
> requires /bin/bash,
>     but no providers found in RDEPENDS_libkcapi? [file-rdeps]
>
> Signed-off-by: Krzysztof Kozlowski <krzk at kernel.org>
> ---
>  meta-oe/recipes-crypto/libkcapi/libkcapi_git.bb | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-crypto/libkcapi/libkcapi_git.bb
> b/meta-oe/recipes-crypto/libkcapi/libkcapi_git.bb
> index a93ddc823740..f70f774bf2d6 100644
> --- a/meta-oe/recipes-crypto/libkcapi/libkcapi_git.bb
> +++ b/meta-oe/recipes-crypto/libkcapi/libkcapi_git.bb
> @@ -16,13 +16,17 @@ SRC_URI = " \
>  inherit autotools
>
>  PACKAGECONFIG ??= ""
> -PACKAGECONFIG[testapp] = "--enable-kcapi-test,,,"
> +PACKAGECONFIG[testapp] = "--enable-kcapi-test,,,bash"
>  PACKAGECONFIG[apps] = "--enable-kcapi-speed --enable-kcapi-hasher
> --enable-kcapi-rngapp --enable-kcapi-encapp --enable-kcapi-dgstapp,,,"
>
>  do_install_append() {
>      # bindir contains testapp and apps.  However it is always created,
> even
>      # when no binaries are installed (empty bin_PROGRAMS in Makefile.am),
>      rmdir --ignore-fail-on-non-empty ${D}${bindir}
> +
> +    # Remove the generated binary checksum files
> +    rm -f ${D}${bindir}/.*.hmac
> +    rm -f ${D}${libdir}/.*.hmac
>  }
>
>  CPPFLAGS_append_libc-musl_toolchain-clang = " -Wno-error=sign-compare"
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>