[oe] [meta-gnome][PATCH] gnome-system-monitor: Add DEPENDS on polkit

[Martin Jansa]

It does tell that there are errors, but we don't want errors in "bitbake
world" :).

inherit distro_features_check
REQUIRED_DISTRO_FEATURES = "polkit"

tells the same for gnome-system-monitor directly without showing any errors
(because it's automatically skipped when polkit isn't in DISTRO_FEATURES).

On Sun, Jul 28, 2019 at 6:20 PM Adrian Bunk <bunk at stusta.de> wrote:

> On Sun, Jul 28, 2019 at 08:32:37AM -0700, Khem Raj wrote:
> >
> > On 7/28/19 3:52 AM, Adrian Bunk wrote:
> > > The build fails without polkit in DISTRO_FEATURES:
> > > FAILED: org.gnome.gnome-system-monitor.policy
> > > msgfmt: cannot locate ITS rules for
> org.gnome.gnome-system-monitor.policy.in
> > >
> > > Signed-off-by: Adrian Bunk <bunk at stusta.de>
> > > ---
> > >   .../gnome-system-monitor/gnome-system-monitor_3.32.0.bb          |
> 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/meta-gnome/recipes-gnome/gnome-system-monitor/
> gnome-system-monitor_3.32.0.bb
> b/meta-gnome/recipes-gnome/gnome-system-monitor/
> gnome-system-monitor_3.32.0.bb
> > > index 701b0891c..8d39101e9 100644
> > > --- a/meta-gnome/recipes-gnome/gnome-system-monitor/
> gnome-system-monitor_3.32.0.bb
> > > +++ b/meta-gnome/recipes-gnome/gnome-system-monitor/
> gnome-system-monitor_3.32.0.bb
> > > @@ -10,6 +10,7 @@ DEPENDS = " \
> > >       gtkmm3 \
> > >       libgtop \
> > >       librsvg \
> > > +    polkit \
> > >   "
> > this should be probably guarded with polkit as DISTRO_FEATURE knob as
> well.
>
> The error message already tells that automatically:
>
> ERROR: Nothing PROVIDES 'polkit' (but
> /home/bunk/sources/meta-openembedded/meta-gnome/recipes-gnome/gnome-system-monitor/
> gnome-system-monitor_3.32.0.bb DEPENDS on or otherwise requires it)
> polkit was skipped: missing required distro feature 'polkit' (not in
> DISTRO_FEATURES)
> ERROR: Required build target 'gnome-system-monitor' has no buildable
> providers.
> Missing or unbuildable dependency chain was: ['gnome-system-monitor',
> 'polkit']
>
>
> cu
> Adrian
>
> --
>
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>