[oe] [meta-java][PATCH 01/23] icedtea7: Add x11 as default pkgconfig

[Ricardo Ribalda Delgado]

Hi

On Tue, Jun 25, 2019 at 11:04 AM Jacob Kroon <jacob.kroon at mikrodidakt.se> wrote:
>
> Hi Ricardo,
>
> FYI, I notice that we have gone off-list.

Sorry, not on purpose :S

Will try also with that

thanks

>
> You probably need to add more dependencies as you iterate the builds.
>
> It looks like "libx11-native" is missing now.
>
> /Jacob
>
> On 6/25/19 10:57 AM, Ricardo Ribalda Delgado wrote:
> > Hi Jacob
> >
> > Unfortunately it crashes at do_compile: :(
> >
> > build-boot/tmp/sun/sun.awt/awt/obj64/Disposer.o
> > ../../../src/share/native/sun/awt/../java2d/Disposer.c
> > | In file included from
> > ../../../src/share/native/sun/awt/../java2d/pipe/Region.h:34:0,
> > |                  from
> > ../../../src/share/native/sun/awt/../java2d/pipe/Region.c:30:
> > | ../../../src/solaris/native/sun/awt/utility/rect.h:31:22: fatal
> > error: X11/Xlib.h: No such file or directory
> > |  #include <X11/Xlib.h>
> > |                       ^
> > | compilation terminated.
> > | make[6]: *** [/workdir/build/tmp/work/x86_64-linux/icedtea7-native/2.1.3-r1.0/icedtea-2.1.3/build/openjdk-boot/jdk/make/common/internal/NativeCompileRules.gmk:75:
> > /workdir/build/tmp/work/x86_64-linux/icedtea7-native/2.1.3-r1.0/icedtea-2.1.3/build/openjdk.build-boot/tmp/sun/sun.awt/awt/obj64/Region.o]
> > Error 1
> > | make[6]: *** Waiting for unfinished jobs....
> >
> > So the initial proposal stays. Unless you want to fix it :P
> >
> > Cheers!
> >
> > On Tue, Jun 25, 2019 at 10:44 AM Ricardo Ribalda Delgado
> > <ricardo at ribalda.com> wrote:
> >>
> >> Hi Jacob
> >>
> >>
> >> On Tue, Jun 25, 2019 at 10:35 AM Jacob Kroon <jacob.kroon at mikrodidakt.se> wrote:
> >>>
> >>> Hi Ricardo,
> >>>
> >>> On 6/25/19 9:52 AM, Ricardo Ribalda Delgado wrote:
> >>>> Seems to be a basic dependency, not optional.
> >>>>
> >>>> Fixes:
> >>>> | checking X11/X.h usability... no
> >>>> | checking X11/X.h presence... no
> >>>> | checking for X11/X.h... no
> >>>> | configure: error: "xorg headers were not found -
> >>>> | try installing xorg-x11-proto-devel."
> >>>> | NOTE: The following config.log files may provide further information.
> >>>> | NOTE: /workdir/build/tmp/work/x86_64-linux/icedtea7-native/2.1.3-r1.0/icedtea-2.1.3/build/config.log
> >>>> | ERROR: configure failed
> >>>> | WARNING: exit code 1 from a shell command.
> >>>> | ERROR: Function failed: do_configure (log file is located at /workdir/build/tmp/work/x86_64-linux/icedtea7-native/2.1.3-r1.0/temp/log.do_configure.29594)
> >>>> ERROR: Task (/workdir/repo/poky/../meta-java/recipes-core/icedtea/icedtea7-native_2.1.3.bb:do_configure) failed with exit code '1'
> >>>>
> >>>> Signed-off-by: Ricardo Ribalda Delgado <ricardo at ribalda.com>
> >>>> ---
> >>>>    recipes-core/icedtea/icedtea7-native.inc | 2 +-
> >>>>    1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/recipes-core/icedtea/icedtea7-native.inc b/recipes-core/icedtea/icedtea7-native.inc
> >>>> index 69f5d25..747bb72 100644
> >>>> --- a/recipes-core/icedtea/icedtea7-native.inc
> >>>> +++ b/recipes-core/icedtea/icedtea7-native.inc
> >>>> @@ -11,7 +11,7 @@ DEPENDS = "virtual/javac-native virtual/java-native classpath-native \
> >>>>       unzip-native make-native util-linux-native\
> >>>>              "
> >>>>
> >>>> -PACKAGECONFIG ??= ""
> >>>> +PACKAGECONFIG ??= "x11"
> >>>>    PACKAGECONFIG[x11] = ",--disable-headful,libx11-native xorgproto-native libxt-native libxext-native libxrender-native"
> >>>>
> >>>>    OEMAKE_BUILD_HEADLESS_ONLY = "${@bb.utils.contains('PACKAGECONFIG', 'x11', '', 'BUILD_HEADLESS_ONLY=1', d)}"
> >>>>
> >>>
> >>> I have run into this as well; instead of turning on x11 by default,
> >>> wouldn't it be better to add "xorgproto-native" to DEPENDS ? I doubt the
> >>> native build needs x11 support in most cases.
> >>
> >> That is definitely better. I have fixed the patch on
> >> https://github.com/ribalda/meta-java/commit/1f48e7d72ac9eeb45b5d9c872e95e3b32fd74f8d
> >>
> >> I will resend the set when I get more comments
> >>
> >> Thanks!
> >>
> >>>
> >>> /Jacob
> >>>
> >>>
> >>> [mikrodidakt]
> >>> Jacob Kroon • +46 46325040
> >>>
> >>> mikrodidakt.se • Skiffervägen 48, SE-224 78 LUND, Sweden
> >>>
> >>> Consultans since 1980 • SW, HW, Embedded Systems, Linux
> >>>
> >>>
> >>
> >>
> >> --
> >> Ricardo Ribalda
> >
> >
> >
>
>
> [mikrodidakt]
> Jacob Kroon • +46 46325040
>
> mikrodidakt.se • Skiffervägen 48, SE-224 78 LUND, Sweden
>
> Consultans since 1980 • SW, HW, Embedded Systems, Linux
>
>


-- 
Ricardo Ribalda