[oe] [oe-commits] [meta-openembedded] 04/06: fluidsynth: Explicitly disable readline support

[Andreas Müller]

On Wed, May 8, 2019 at 11:35 PM <git at git.openembedded.org> wrote:
>
> This is an automated email from the git hooks/post-receive script.
>
> khem pushed a commit to branch master-next
> in repository meta-openembedded.
>
> commit 07f0d6fed45f6f6148b5e6634e543c9fff0e1fbd
> Author: Adrian Bunk <bunk at stusta.de>
> AuthorDate: Wed May 8 22:58:51 2019 +0300
>
>     fluidsynth: Explicitly disable readline support
>
>     readline is GPL, so make it explicit that it shouldn't
>     be enabled accidentally.
>
>     Signed-off-by: Adrian Bunk <bunk at stusta.de>
>     Signed-off-by: Khem Raj <raj.khem at gmail.com>
> ---
>  meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_git.bb b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_git.bb
> index 4f600a2..9a8cb87 100644
> --- a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_git.bb
> +++ b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_git.bb
> @@ -8,7 +8,7 @@ SRC_URI += " \
>      file://0003-Use-ARM-NEON-accelaration-for-float-multithreaded-se.patch \
>  "
>
> -EXTRA_OECMAKE = "-Denable-floats=ON -DLIB_SUFFIX=${@d.getVar('baselib').replace('lib', '')}"
> +EXTRA_OECMAKE = "-Denable-floats=ON -DLIB_SUFFIX=${@d.getVar('baselib').replace('lib', '')} -Denable-readline=OFF"
>
>  do_configure_append() {
>      make_tables.exe ${B}/
>
Have to be more clear here:

NAK

It removes history functionality from fluidsynth console. This is
extremely useful for benchmarking because results vary and entering
same commands over and over again is just tedious waste of time (did
that for the NEON patch)

Unfortunately this code is part of the library so just not installing
fluidsynth-bin won't help.
So pleaaaaase add a PACKAGECONFIG for this (with whatever default - I
am tired of strange priorities in here)

Andreas