[oe] [meta-oe][warrior][thud][PATCH] cpupower: remove LIC_FILES_CHKSUM

Nicolas Dechesne nicolas.dechesne at linaro.org
Fri May 10 17:41:02 UTC 2019


cpupower is a 'special' recipe since it does "inherit kernelsrc" ,
which essentially means that it doesn't have its own sources, but
reuse the kernel source tree, from virtual/kernel recipe. As such,
checking the license file in cpupower recipe does not seem relevant,
since it does not fetch anything (kernelsrc has "deltask do_fetch")
and the fetching is deferred to the virtual/kernel recipe.

so we are basically checking the COPYING file twice. If there was any
license issue, it would have been caught by virtual/kernel recipe
already.

Hence we remove LIC_FILES_CHKSUM like it is done for perf recipe in
OE-core in meta/recipes-kernel/perf/perf.bb.

It has the nice side effect that BSP layers can use different kernel
versions without worrying about any LICENSE checksum changes in
between kernel versions.

Reported-by: Daniel Díaz <daniel.diaz at linaro.org>
Signed-off-by: Nicolas Dechesne <nicolas.dechesne at linaro.org>
Signed-off-by: Khem Raj <raj.khem at gmail.com>
(cherry picked from commit 7142f09407b81c2221bbf1c5078641ab4bc63ee9)
---
Armin, for our use cases (at least) this is a bug fix, since we use
different kernel versions in our BSP layers.. I am hoping you will
agree to merge it is -stable branches. If you can apply to warrior and thud
where it applies cleanly that would be really nice. It won't apply on sumo, 
i can send another patch later for sumo.
---
 meta-oe/recipes-kernel/cpupower/cpupower.bb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta-oe/recipes-kernel/cpupower/cpupower.bb b/meta-oe/recipes-kernel/cpupower/cpupower.bb
index 928973871..abf1585de 100644
--- a/meta-oe/recipes-kernel/cpupower/cpupower.bb
+++ b/meta-oe/recipes-kernel/cpupower/cpupower.bb
@@ -2,7 +2,6 @@ SUMMARY = "Shows and sets processor power related values"
 DESCRIPTION = "cpupower is a collection of tools to examine and tune power \
 saving related features of your processor."
 LICENSE = "GPLv2"
-LIC_FILES_CHKSUM = "file://COPYING;md5=bbea815ee2795b2f4230826c0c6b8814"
 DEPENDS = "pciutils gettext-native"
 PROVIDES = "virtual/cpupower"
 
-- 
2.20.1



More information about the Openembedded-devel mailing list