[oe] [oe-commits] [meta-openembedded] 02/09: mozjs: Upgrade to version 60.x

[Andreas Müller]

On Wed, May 22, 2019 at 11:34 PM Khem Raj <raj.khem at gmail.com> wrote:
>
> On Wed, May 22, 2019 at 2:29 PM Andreas Müller <schnitzeltony at gmail.com> wrote:
> >
> > On Wed, May 22, 2019 at 10:14 PM Khem Raj <raj.khem at gmail.com> wrote:
> > >
> > > On Wed, May 22, 2019 at 12:06 PM Andreas Müller <schnitzeltony at gmail.com> wrote:
> > > >
> > > > On Wed, May 22, 2019 at 5:50 PM <git at git.openembedded.org> wrote:
> > > > >
> > > > > This is an automated email from the git hooks/post-receive script.
> > > > >
> > > > > khem pushed a commit to branch master-next
> > > > > in repository meta-openembedded.
> > > > >
> > > > > commit 8587370567e7f2f398ae1efa77989b1110d15a77
> > > > > Author: Khem Raj <raj.khem at gmail.com>
> > > > > AuthorDate: Tue May 21 23:27:16 2019 -0700
> > > > >
> > > > >     mozjs: Upgrade to version 60.x
> > > > >
> > > > Haven't found this on mailing list so:
> > > >
> > > > I ve done similar here and I saw that
> > > >
> > > > * musl patch can go (tested)
> > > > * polkit needs update - current version requires mozjs 52.x (shall I
> > > > send the patch I have already?)
> > > >
> > >
> > > Please do. I am currently trying to upgrade polkit to 0.116 which
> > > should work with
> > > spidermonkey 60.x so if you have patches please send, I would be happy
> > > to give them a shot.
> > >
> > That might take till weekend: am sitting on 60+ patches not quite
> > ready for the wild. So I have to rebase (and test).
> >
> > Ahh  - and after staring python2 crusade accidentally: If you give me
> > a bit more time I would create a patch to move mozjs build to python3.
> > Found a patch which is a good base to steel from.
> >
>
> OK. I have it compiling and working on rpi3 and qemux86-64
> see top 4 patches
> https://git.openembedded.org/meta-openembedded-contrib/log/?h=yoe/mut
>
> Let me know what you think
>
Seems you chose same way as I did: add necessary python dependencies.
Now after recent discussion about python2 I don't like this way. E.g
python-which has seen last release in 2010 [1] and does not build for
python3.

By looking into the python3 patch for mozjs [2] I found that mozjs
ships the python scripts required (and I think much more). Seems we do
not set it up properly so that it cannot find them.

My target for mozjs is:
Use the python-scripts found in mozjs 'third_party' folder, patch them
for python3 and don't add python-native recipes.

Suggestion:
* If you are under pressure for this issue for other recipes: Take
your patches - I can make those modifications on top later.
* If there is no pressure just give me a bit of time

And finally: Maybe we do same in parallel. To avoid double efforts: My
WIP is at [3] As said it is not ready to send: Have not seen
gnome-desktop yet and would like to add śome more as gdm / eog...

Time for zzz

Andreas

[1] https://pypi.org/project/which/
[2] https://code.foxkit.us/adelie/packages/blob/f2b5773da19ab397fbe64fd32dacc383cfe4cd77/user/mozjs/python3.patch
[3] https://github.com/schnitzeltony/meta-openembedded/tree/work-2019-05