[oe] [meta-oe][PATCHv2] surf: Add a simple web browser

[Khem Raj]

On Fri, 2019-11-15 at 15:27 +0200, Leon Anavi wrote:
> Add a recipe for surf, a simple web browser based on WebKit2/GTK+.
> 
> Signed-off-by: Leon Anavi <leon.anavi at konsulko.com>
> ---
>  .../0001-config.mk-Fix-compiler-and-linker.patch   | 36
> ++++++++++++++++++++++
>  meta-oe/recipes-graphics/surf/surf_2.0.bb          | 31
> +++++++++++++++++++
>  2 files changed, 67 insertions(+)
>  create mode 100644 meta-oe/recipes-graphics/surf/surf/0001-
> config.mk-Fix-compiler-and-linker.patch
>  create mode 100644 meta-oe/recipes-graphics/surf/surf_2.0.bb
> 
> diff --git a/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-
> compiler-and-linker.patch b/meta-oe/recipes-graphics/surf/surf/0001-
> config.mk-Fix-compiler-and-linker.patch
> new file mode 100644
> index 0000000..a3e33ea
> --- /dev/null
> +++ b/meta-oe/recipes-graphics/surf/surf/0001-config.mk-Fix-compiler-
> and-linker.patch
> @@ -0,0 +1,36 @@
> +From df199f82752398f86d2332dce53f52e2cfb50c87 Mon Sep 17 00:00:00
> 2001
> +From: Leon Anavi <leon.anavi at konsulko.com>
> +Date: Thu, 14 Nov 2019 14:28:39 +0000
> +Subject: [PATCH] config.mk: Fix compiler and linker
> +
> +Do not set explicitly compiler and linker.
> +
> +Signed-off-by: Leon Anavi <leon.anavi at konsulko.com>
> +---
> + config.mk | 6 +++---
> + 1 file changed, 3 insertions(+), 3 deletions(-)
> +
> +diff --git a/config.mk b/config.mk
> +index df6e812..bf07406 100644
> +--- a/config.mk
> ++++ b/config.mk
> +@@ -15,8 +15,8 @@ GTKINC = `pkg-config --cflags gtk+-3.0 webkit2gtk-
> 4.0`
> + GTKLIB = `pkg-config --libs gtk+-3.0 webkit2gtk-4.0`
> + 
> + # includes and libs
> +-INCS = -I. -I/usr/include -I${X11INC} ${GTKINC}
> +-LIBS = -L/usr/lib -lc -L${X11LIB} -lX11 ${GTKLIB} -lgthread-2.0
> ++INCS = ${GTKINC}
> ++LIBS = -lc -lX11 ${GTKLIB} -lgthread-2.0
> + 
> + # flags
> + CPPFLAGS = -DVERSION=\"${VERSION}\" -DWEBEXTDIR=\"${LIBPREFIX}\"
> -D_DEFAULT_SOURCE
> +@@ -28,4 +28,4 @@ LDFLAGS = -s ${LIBS}
> + #LDFLAGS = ${LIBS}
> + 
> + # compiler and linker
> +-CC = cc
> ++#CC = cc

this should be ?= instead of commenting out and you can upstream this
change

> +-- 
> +2.7.4
> +
> diff --git a/meta-oe/recipes-graphics/surf/surf_2.0.bb b/meta-
> oe/recipes-graphics/surf/surf_2.0.bb
> new file mode 100644
> index 0000000..7639137
> --- /dev/null
> +++ b/meta-oe/recipes-graphics/surf/surf_2.0.bb
> @@ -0,0 +1,31 @@
> +SUMMARY = "Simple web browser"
> +DESCRIPTION = "Simple open source web browser based on WebKit2/GTK"
> +HOMEPAGE = "https://surf.suckless.org/"
> +SECTION = "x11/graphics"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM =
> "file://LICENSE;md5=b57e7f7720307a02d5a6598b00fe3afa"
> +
> +DEPENDS = "webkitgtk gtk+ gtk+3 glib-2.0"
> +
> +REQUIRED_DISTRO_FEATURES = "x11"
> +
> +SRC_URI = "git://git.suckless.org/surf;branch=surf-webkit2 \
> +           file://0001-config.mk-Fix-compiler-and-linker.patch \
> +"
> +SRCREV = "b814567e2bf8bda07cea8de1c7a062f4aa437b65"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit pkgconfig distro_features_check

my original question about sstate issue perhaps is still not addressed

> +
> +TARGET_CC_ARCH += "${LDFLAGS}"
> +
> +do_install () {
> +	install -d ${D}${bindir}
> +	install -m 0644 ${S}/surf ${D}${bindir}
> +	chmod +x ${D}${bindir}/surf
> +}
> +
> +# Avoid already-stripped QA errors
> +INHIBIT_PACKAGE_DEBUG_SPLIT = "1"

this needs explanation why we need this.

> +INHIBIT_PACKAGE_STRIP = "1"
> -- 
> 2.7.4
>