[oe] [meta-networking][PATCH] strongswan: add a PACKAGECONFIG for libbfd stack traces

[Khem Raj]

On Mon, Oct 14, 2019 at 3:01 AM Dan Callaghan <dan.callaghan at opengear.com>
wrote:

> Strongswan installs a signal handler for SIGSEGV, SIGILL, and SIGBUS
> which attempts to print a stack trace of the crash. For producing line
> numbers in the stack trace, it can use libbfd from binutils, or
> libunwind, or else it falls back to a slower method using
> /usr/bin/addr2line.
>
> Currently the addr2line method is unlikely to actually work, since there
> is no RDEPENDS to pull that command into the image.
>
> This patch turns on the libbfd-based stack traces by default, which
> should be a reasonable choice since binutils is already required for
> building everything. The setting is nevertheless behind a PACKAGECONFIG
> in case libbfd is not wanted in the final image.


Package config is fine but let’s not enable it by default


> ---
>  meta-networking/recipes-support/strongswan/strongswan_5.8.1.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-networking/recipes-support/strongswan/
> strongswan_5.8.1.bb b/meta-networking/recipes-support/strongswan/
> strongswan_5.8.1.bb
> index 5408eed27..c8a8d1dc0 100644
> --- a/meta-networking/recipes-support/strongswan/strongswan_5.8.1.bb
> +++ b/meta-networking/recipes-support/strongswan/strongswan_5.8.1.bb
> @@ -24,10 +24,11 @@ EXTRA_OECONF = " \
>
>  EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd',
> '--with-systemdsystemunitdir=${systemd_unitdir}/system/',
> '--without-systemdsystemunitdir', d)}"
>
> -PACKAGECONFIG ??= "charon curl gmp openssl stroke sqlite3 \
> +PACKAGECONFIG ??= "bfd charon curl gmp openssl stroke sqlite3 \
>          ${@bb.utils.filter('DISTRO_FEATURES', 'ldap', d)} \
>  "
>  PACKAGECONFIG[aesni] =
> "--enable-aesni,--disable-aesni,,${PN}-plugin-aesni"
> +PACKAGECONFIG[bfd] =
> "--enable-bfd-backtraces,--disable-bfd-backtraces,binutils"
>  PACKAGECONFIG[charon] = "--enable-charon,--disable-charon,"
>  PACKAGECONFIG[curl] =
> "--enable-curl,--disable-curl,curl,${PN}-plugin-curl"
>  PACKAGECONFIG[gmp] = "--enable-gmp,--disable-gmp,gmp,${PN}-plugin-gmp"
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>