[oe] [warrior 04/23] network-manager-applet: Remove obsolete dbus-glib and libnm-glib dependencies

Adrian Bunk bunk at stusta.de
Sun Sep 1 06:39:54 UTC 2019


On Sat, Aug 31, 2019 at 02:31:25PM -0700, Armin Kuster wrote:
> From: Adrian Bunk <bunk at stusta.de>
> 
> network-manager-applet stopped using dbus-glib 3 years ago.
> 
> Building of the obsolete libnm-gtk is disabled by default in 1.8.20.
>...

This commit is not really appropriate for stable branches.

> --- a/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.20.bb
> +++ b/meta-gnome/recipes-connectivity/network-manager-applet/network-manager-applet_1.8.20.bb
> @@ -2,7 +2,7 @@ SUMMARY = "GTK+ applet for NetworkManager"
>  LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
>  
> -DEPENDS = "gtk+3 libnotify libsecret networkmanager dbus-glib \
> +DEPENDS = "gtk+3 libnotify libsecret networkmanager \
>...

That's a cleanup change removing an unused build dependency with
no (intentional) changes to the built binaries.

> --- a/meta-gnome/recipes-connectivity/networkmanager/networkmanager_%.bbappend
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -# networkmanager-applet requires glib support
> -PACKAGECONFIG_append = " glib"
>...

The bbappend might not be nice, but removing it would be a behaviour 
change in a stable branch.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



More information about the Openembedded-devel mailing list