[oe] [meta-networking][PATCH] wireshark: remove restriction to ARM ISA

[S. Lockwood-Childs]

On Wed, Sep 18, 2019 at 06:54:59PM -0700, Khem Raj wrote:
> On Wed, Sep 18, 2019 at 6:51 PM S. Lockwood-Childs <sjl at vctlabs.com> wrote:
> >
> > The restriction to ARM instruction set came in the original
> > wireshark recipe, which was 2 major versions ago (and also
> > a few toolchains ago). Wireshark 3.x seems to be building
> > fine allowing thumb instructions, at least on cortexa9t2hf.
> > ---
> >  meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb b/meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb
> > index efcd5e4..6de188d 100644
> > --- a/meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb
> > +++ b/meta-networking/recipes-support/wireshark/wireshark_3.0.3.bb
> > @@ -19,8 +19,6 @@ PE = "1"
> >
> >  inherit cmake pkgconfig python3native perlnative upstream-version-is-even
> >
> > -ARM_INSTRUCTION_SET = "arm"
> 
> it will be interesting to see if it is still the case with thumb1 on <= armv5t
> earlier we use to test qrmarm with thumb, maybe build with
> 
> MACHINE=qemuarmv5 and in recipe set
> 
> ARM_INSTRUCTION_SET = "thumb"
> 
> and see if it still builds.
> 
> If not them limit this setting to arch <= v6

Yes, it did still build with MACHINE=qemuarmv5 and

-ARM_INSTRUCTION_SET = "arm"
+ARM_INSTRUCTION_SET = "thumb"

I don't even see any warnings in log.do_compile either