[oe] [meta-networking][PATCH 1/2] spice: append -Wno-error=address-of-packed-member only for target

[Khem Raj]

On Fri, Sep 27, 2019 at 12:42 AM Martin Jansa <martin.jansa at gmail.com> wrote:
>
> Why? there are many PACKAGECONFIGs for optional dependencies which aren't
> in the same layer as the recipe with that PACKAGECONFIG.
>
> As long as it's not enabled by default it is correct to have the
> PACKAGECONFIG to control the dependency explicitly.
>

right

> Cheers,
>
> On Fri, Sep 27, 2019 at 9:20 AM Robert Yang <liezhi.yang at windriver.com>
> wrote:
>
> > Hi Martin,
> >
> > We found another problem on spice_git.bb:
> >
> > PACKAGECONFIG[smartcard] =
> > "--enable-smartcard,--disable-smartcard,libcacard,"
> >
> > I can't find libcacard:
> >
> >
> > http://layers.openembedded.org/layerindex/branch/master/recipes/?q=libcacard
> >
> >
> > So it seems that this PACKAGECONFIG is invalid, should we remove it?
> >
> > // Robert
> >
> > On 9/27/19 11:56 AM, Robert Yang wrote:
> > >
> > >
> > > On 9/27/19 3:48 AM, Adrian Bunk wrote:
> > >> On Thu, Sep 26, 2019 at 04:26:54PM +0000, Martin Jansa wrote:
> > >>> * with older native gcc on host this will break spice-native with:
> > >>>    cc1: error: -Werror=address-of-packed-member: no option
> > >>> -Waddress-of-packed-member
> > >>>
> > >>> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> > >>> ---
> > >>>   meta-networking/recipes-support/spice/spice_git.bb | 2 +-
> > >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> > >>>
> > >>> diff --git a/meta-networking/recipes-support/spice/spice_git.bb
> > >>> b/meta-networking/recipes-support/spice/spice_git.bb
> > >>> index 30e939ac07..2829a59d15 100644
> > >>> --- a/meta-networking/recipes-support/spice/spice_git.bb
> > >>> +++ b/meta-networking/recipes-support/spice/spice_git.bb
> > >>> @@ -37,7 +37,7 @@ DEPENDS_append_class-nativesdk = "nativesdk-openssl"
> > >>>   export PYTHON="${STAGING_BINDIR_NATIVE}/python-native/python"
> > >>>   export
> > PYTHONPATH="${PKG_CONFIG_SYSROOT_DIR}${libdir}/python2.7/site-packages"
> > >>> -CFLAGS_append = " -Wno-error=address-of-packed-member"
> > >>> +CFLAGS_append_class-target = " -Wno-error=address-of-packed-member"
> > >
> > > Yes, the error was the same as you mentioned in the commit message, and
> > > "bitbake spice-native" works with this change.
> > >
> > >>> ...
> > >>
> > >> Least hassle would be
> > >>    CFLAGS_append = " -Wno-error"
> > >
> > > "bitbake nativesdk-spice" works with this change, otherwise, it doesn't
> > work.
> > >
> > > This patch works for me.
> > >
> > > // Robert
> > >
> > >>
> > >> cu
> > >> Adrian
> > >>
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel