[oe] [meta-python][zeus][PATCH v2 1/2] python-twisted: add required RDEPENDS for twistd

[Trevor Gamblin]

On 2/3/20 9:46 PM, Tim Orling wrote:
> Thank you for sorting :)
>
> I was looking at applying this to meta-python2 zeus and my checks 
> (import every twisted and twisted.* module) didn't see any missing 
> dependencies before this patch. Can you describe the need or give me a 
> hint of a reproducer? I'm sure I'm missing something.
The /usr/bin/twistd executable will complain about the dependencies 
being missing. You don't need to pass it any config files to test it - 
it'll output usage info if the dependencies are present.
>
> On Fri, Jan 31, 2020 at 1:29 AM Trevor Gamblin 
> <Trevor.Gamblin at windriver.com <mailto:Trevor.Gamblin at windriver.com>> 
> wrote:
>
>     From: Trevor Gamblin <trevor.gamblin at windriver.com
>     <mailto:trevor.gamblin at windriver.com>>
>
>     python-twisted is currently missing some packages for its
>     /usr/bin/twistd
>     executable to function. Add these to the RDEPENDS list, and also
>     clean up
>     formatting since the list is getting long.
>
>     Note that a similar patch has already been submitted for master
>     branch,
>     but the python2 version of twisted needs more explicit RDEPENDS
>     than the
>     python3 version submitted to master in order for /usr/bin/twistd
>     to work
>     properly.
>
>     Signed-off-by: Trevor Gamblin <trevor.gamblin at windriver.com
>     <mailto:trevor.gamblin at windriver.com>>
>     ---
>      .../recipes-devtools/python/python-twisted.inc | 18
>     +++++++++++++++++-
>      1 file changed, 17 insertions(+), 1 deletion(-)
>
>     diff --git
>     a/meta-python/recipes-devtools/python/python-twisted.inc
>     b/meta-python/recipes-devtools/python/python-twisted.inc
>     index d70104dc2..024a9fa7c 100644
>     --- a/meta-python/recipes-devtools/python/python-twisted.inc
>     +++ b/meta-python/recipes-devtools/python/python-twisted.inc
>     @@ -56,7 +56,23 @@ RDEPENDS_${PN} = "\
>          ${PN}-zsh \
>      "
>
>     -RDEPENDS_${PN}-core = "${PYTHON_PN}-core
>     ${PYTHON_PN}-zopeinterface ${PYTHON_PN}-incremental
>     ${PYTHON_PN}-constantly ${PYTHON_PN}-hyperlink ${PYTHON_PN}-automat"
>     +RDEPENDS_${PN}-core = "${PYTHON_PN}-automat \
>     +                       ${PYTHON_PN}-constantly \
>     +                       ${PYTHON_PN}-core \
>     +                      ${PYTHON_PN}-debugger \
>     +                       ${PYTHON_PN}-hyperlink \
>     +                       ${PYTHON_PN}-incremental \
>     +                       ${PYTHON_PN}-misc \
>     +                       ${PYTHON_PN}-pkg-resources \
>     +                       ${PYTHON_PN}-pkgutil \
>     +                       ${PYTHON_PN}-plistlib \
>     +                       ${PYTHON_PN}-pyhamcrest \
>     +                       ${PYTHON_PN}-pyserial \
>     +                       ${PYTHON_PN}-setuptools \
>     +                       ${PYTHON_PN}-unixadmin \
>     +                       ${PYTHON_PN}-zopeinterface \
>     +"
>     +
>      RDEPENDS_${PN}-test = "${PN}"
>      RDEPENDS_${PN}-conch = "${PN}-core ${PN}-protocols"
>      RDEPENDS_${PN}-mail = "${PN}-core ${PN}-protocols"
>     -- 
>     2.24.0
>
>     -- 
>     _______________________________________________
>     Openembedded-devel mailing list
>     Openembedded-devel at lists.openembedded.org
>     <mailto:Openembedded-devel at lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>