[oe] [meta-python][zeus][PATCH v2 1/2] python-twisted: add required RDEPENDS for twistd

Wed Feb 5 14:59:39 UTC 2020

On Mon, Feb 03, 2020 at 08:45:26PM -0800, Tim Orling wrote:
> On Mon, Feb 3, 2020 at 8:30 PM Martin Jansa <martin.jansa at gmail.com> wrote:
> 
> > Please send this fix to normal meta-python in meta-oe/zeus:
> >
> > http://git.openembedded.org/meta-openembedded/tree/meta-python/recipes-devtools/python/python-twisted.inc?h=zeus
> >
> > BTW: Why are you using meta-python2 with zeus branch? It imho doesn't have
> > anything which would be missing in oe-core+meta-oe zeus branch and fixes
> > like this should be resolved also for people using zeus branch without
> > overlaying them by meta-python2.
> >
> >
> Because, as I believe I have said before, I need a prior release to test
> the infrastructure on. zeus allows me to work on more than just master
> until we have the next stable release branching.

The question was for Trevor, I understood that you wanted zeus branch to
test the infrastructure, but I still don't understand why any "project"
should use meta-python2/zeus for the python2 bits which are still in
oe-core/zeus + meta-python/zeus.

I see that there are some differences in the recipes in zeus, e.g.:

martin at jama:/OE/meta-python2$ diff recipes-devtools/python/python-configparser_3.8.1.bb ../meta-openembedded/meta-python/recipes-devtools/python/python-configparser_3.8.1.bb
1c1
< inherit setuptools python-backports-init
---
> inherit setuptools
martin at jama:/OE/meta-python2$ diff recipes-devtools/python/python-dbus_1.2.12.bb ../meta-openembedded/meta-python/recipes-devtools/python/python-dbus_1.2.12.bb
18,19c18,19
< # documentation needs python-sphinx, which is not in oe-core or meta-python2 for now
< # change to use PACKAGECONFIG when python-sphinx is added to oe-core or meta-python2
---
> # documentation needs python-sphinx, which is not in oe-core or meta-python for now
> # change to use PACKAGECONFIG when python-sphinx is added to oe-core or meta-python

But README nor your reply explained to me, what's the benefit of using meta-python2/zeus
instead of the existing python2 recipes which are in oe-core and meta-oe zeus. That's why
I've never tried to use it with zeus, nor submitted the python-numpy and python-nose
recipes which got removed from oe-core/zeus, but weren't re-introduced in meta-python2
python-nose was removed in:
http://git.openembedded.org/openembedded-core/commit/?h=zeus&id=9f07b2836405d86e869780f8f1ae00843eadc409
python-numpy in:
http://git.openembedded.org/openembedded-core/commit/?h=zeus&id=4e9659f24e2f699effadcbe378b6a746d77ccdbd
from oe-core/zeus.

> It has nothing to do with what is missing from meta-oe, it is a viable
> alternative that also helps prove out my workflow as I have EXTREMELY
> LIMITED TIME to support this.

Understood, thanks for doing this work, I'm happy to use and contribute to
master branch, it's just that I still don't understand the purpose of zeus
branch (other than testing the infrastructure by you) and I hope you agree
that bug fixes for python2 issues like the one in this thread belong
to meta-oe/meta-python zeus in first place (because that's the layer which
what most people are probably still using with zeus).

Cheers,

> On Fri, Jan 31, 2020 at 10:29 AM Trevor Gamblin <
> > Trevor.Gamblin at windriver.com> wrote:
> >
> > > From: Trevor Gamblin <trevor.gamblin at windriver.com>
> > >
> > > python-twisted is currently missing some packages for its /usr/bin/twistd
> > > executable to function. Add these to the RDEPENDS list, and also clean up
> > > formatting since the list is getting long.
> > >
> > > Note that a similar patch has already been submitted for master branch,
> > > but the python2 version of twisted needs more explicit RDEPENDS than the
> > > python3 version submitted to master in order for /usr/bin/twistd to work
> > > properly.
> > >
> > > Signed-off-by: Trevor Gamblin <trevor.gamblin at windriver.com>
> > > ---
> > >  .../recipes-devtools/python/python-twisted.inc | 18 +++++++++++++++++-
> > >  1 file changed, 17 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/meta-python/recipes-devtools/python/python-twisted.inc
> > > b/meta-python/recipes-devtools/python/python-twisted.inc
> > > index d70104dc2..024a9fa7c 100644
> > > --- a/meta-python/recipes-devtools/python/python-twisted.inc
> > > +++ b/meta-python/recipes-devtools/python/python-twisted.inc
> > > @@ -56,7 +56,23 @@ RDEPENDS_${PN} = "\
> > >      ${PN}-zsh \
> > >  "
> > >
> > > -RDEPENDS_${PN}-core = "${PYTHON_PN}-core ${PYTHON_PN}-zopeinterface
> > > ${PYTHON_PN}-incremental ${PYTHON_PN}-constantly ${PYTHON_PN}-hyperlink
> > > ${PYTHON_PN}-automat"
> > > +RDEPENDS_${PN}-core = "${PYTHON_PN}-automat \
> > > +                       ${PYTHON_PN}-constantly \
> > > +                       ${PYTHON_PN}-core \
> > > +                      ${PYTHON_PN}-debugger \
> > > +                       ${PYTHON_PN}-hyperlink \
> > > +                       ${PYTHON_PN}-incremental \
> > > +                       ${PYTHON_PN}-misc \
> > > +                       ${PYTHON_PN}-pkg-resources \
> > > +                       ${PYTHON_PN}-pkgutil \
> > > +                       ${PYTHON_PN}-plistlib \
> > > +                       ${PYTHON_PN}-pyhamcrest \
> > > +                       ${PYTHON_PN}-pyserial \
> > > +                       ${PYTHON_PN}-setuptools \
> > > +                       ${PYTHON_PN}-unixadmin \
> > > +                       ${PYTHON_PN}-zopeinterface \
> > > +"
> > > +
> > >  RDEPENDS_${PN}-test = "${PN}"
> > >  RDEPENDS_${PN}-conch = "${PN}-core ${PN}-protocols"
> > >  RDEPENDS_${PN}-mail = "${PN}-core ${PN}-protocols"
> > > --
> > > 2.24.0
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel at lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20200205/c6ffd5e7/attachment.sig>