[oe] [meta-oe][PATCH v6] abseil-cpp: add recipe for git version

Sinan Kaya okaya at kernel.org
Tue Feb 11 19:35:23 UTC 2020


On 2/11/2020 2:28 PM, Andrey Zhizhikin wrote:
> Hello Sinan,
> 
> First of - is it a v2 of the previous patch you sent earlier? It was
> not mentioned in the header...

I agree, I am and was lazy. I have been addressing the comments
from Khem. I tried to get it out of my devbox ASAP.

> 
> 
> This sounds to me that if there are no TUNES set - recipe safely
> assumes that Crypto feature is available... Even though it contradicts
> the logic below:

makes sense

> 
>> +        pkgn = d.getVar("PN")
>> +        pkgv = d.getVar("PV")
>> +        if "crypto" not in tunes:
>> +            raise bb.parse.SkipPackage("%s-%s Needs support for crypto on armv8" % (pkgn, pkgv))
> this says: "No Crypto - would not build".
> 
>> +
>> +    if arch == "x86_64":
>> +        tunes = d.getVar("TUNE_FEATURES")
>> +        if not tunes:
>> +            return
> 
> Same here for x86-64...

sure, makes sense

> 
>> +        pkgn = d.getVar("PN")
>> +        pkgv = d.getVar("PV")
>> +        if "corei7" not in tunes:
>> +            raise bb.parse.SkipPackage("%s-%s Needs support for corei7 on x86_64" % (pkgn, pkgv))
>> +
>> +}
>> +
>> --
>> 2.23.0
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 
> 
> 



More information about the Openembedded-devel mailing list