[oe] [meta-oe][PATCH v2] libmimetic: Library to aid multi-part form data parsing

[Khem Raj]

On Thu, Feb 13, 2020 at 1:20 AM <asmithakarun at gmail.com> wrote:
>
> From: asmitha <asmithakarun at gmail.com>
>
> Mimetic library helps parsing the multi-part form data. This library
> can be used for scenarios that includes multi-part form data file uploads
> to the system.
>
> The patch file includes:
> i) The test directory is removed as there were errors (relocation errors)
> since the shared object files of libc++ and libc were not taken from the
> sysroot path but from the system's library path where the required
> version of the .so is not present.
>
> ii) The files 'mimetic/codec/other_codecs.h' and 'mimetic/contenttype.cxx'
> contains changes that resolves errors when compiling on target system
> aarch64-yoe-linux-musl.
>

Thanks for sending a v2, There is another error I see when using clang compiler

mimetic/os/mmfile.cxx:60:14: error: ordered comparison between pointer
and zero ('char *' and 'int')

Details here.
https://errors.yoctoproject.org/Errors/Details/390682/

Will you be able to work on it ?

> Signed-off-by: asmitha <asmithakarun at gmail.com>
> ---
>  ...ing-test-directory-from-the-Makefile.patch | 67 +++++++++++++++++++
>  .../libmimetic/libmimetic_0.9.8.bb            | 21 ++++++
>  2 files changed, 88 insertions(+)
>  create mode 100644 meta-oe/recipes-support/libmimetic/libmimetic/0001-libmimetic-Removing-test-directory-from-the-Makefile.patch
>  create mode 100644 meta-oe/recipes-support/libmimetic/libmimetic_0.9.8.bb
>
> diff --git a/meta-oe/recipes-support/libmimetic/libmimetic/0001-libmimetic-Removing-test-directory-from-the-Makefile.patch b/meta-oe/recipes-support/libmimetic/libmimetic/0001-libmimetic-Removing-test-directory-from-the-Makefile.patch
> new file mode 100644
> index 000000000..50cd4d427
> --- /dev/null
> +++ b/meta-oe/recipes-support/libmimetic/libmimetic/0001-libmimetic-Removing-test-directory-from-the-Makefile.patch
> @@ -0,0 +1,67 @@
> +From 64fd25af5fea3a3c9c12122a2fd0fab3cd420f72 Mon Sep 17 00:00:00 2001
> +From: asmitk01-in <asmitk01 at in.ibm.com>
> +Date: Wed, 5 Feb 2020 00:14:42 -0600
> +Subject: [PATCH] libmimetic: Removing test directory from the Makefile
> +
> +The test directory is removed as there were errors (relocation errors)
> +since the shared object files of libc++ and libc were not taken from the
> +sysroot path but from the system's library path where the required
> +version of the .so is not present.
> +
> +The files 'mimetic/codec/other_codecs.h' and 'mimetic/contenttype.cxx'
> +contains changes that resolves errors when compiling on target system
> +aarch64-yoe-linux-musl.
> +
> +Signed-off-by: asmitk01-in <asmitk01 at in.ibm.com>
> +Change-Id: I1822b36ad4a1fa5e7b165d8cac3a6e96aca11c35
> +---
> + Makefile.am                  | 2 +-
> + mimetic/codec/other_codecs.h | 4 ++++
> + mimetic/contenttype.cxx      | 4 ++++
> + 3 files changed, 9 insertions(+), 1 deletion(-)
> +
> +diff --git a/Makefile.am b/Makefile.am
> +index 634bd4c..c7cbae7 100644
> +--- a/Makefile.am
> ++++ b/Makefile.am
> +@@ -1,6 +1,6 @@
> + MAINTAINERCLEANFILES = Makefile Makefile.in config.cache
> + EXTRA_DIST=LICENSE m4
> +-SUBDIRS = mimetic doc examples test win32
> ++SUBDIRS = mimetic doc examples win32
> + INCLUDES=-I$(top_srcdir)
> + ACLOCAL_AMFLAGS=-I m4
> +
> +diff --git a/mimetic/codec/other_codecs.h b/mimetic/codec/other_codecs.h
> +index c4ccf3f..0fc88fd 100644
> +--- a/mimetic/codec/other_codecs.h
> ++++ b/mimetic/codec/other_codecs.h
> +@@ -8,6 +8,10 @@
> + #define _MIMETIC_CODEC_OTHER_CODECS_H_
> + #include <mimetic/codec/codec_base.h>
> +
> ++#ifndef __GLIBC__
> ++    typedef unsigned int uint;
> ++#endif
> ++
> + namespace mimetic
> + {
> +
> +diff --git a/mimetic/contenttype.cxx b/mimetic/contenttype.cxx
> +index 522082d..0577d44 100644
> +--- a/mimetic/contenttype.cxx
> ++++ b/mimetic/contenttype.cxx
> +@@ -13,6 +13,10 @@
> + #include <mimetic/tokenizer.h>
> + #include <mimetic/utils.h>
> +
> ++#ifndef __GLIBC__
> ++    typedef unsigned int uint;
> ++#endif
> ++
> + namespace mimetic
> + {
> + using namespace std;
> +--
> +2.9.3
> +
> diff --git a/meta-oe/recipes-support/libmimetic/libmimetic_0.9.8.bb b/meta-oe/recipes-support/libmimetic/libmimetic_0.9.8.bb
> new file mode 100644
> index 000000000..fd65db2d3
> --- /dev/null
> +++ b/meta-oe/recipes-support/libmimetic/libmimetic_0.9.8.bb
> @@ -0,0 +1,21 @@
> +# Released under the MIT license.
> +
> +SUMMARY = "Mimetic Library for multi-part parsing"
> +DESCRIPTION = "Email library (MIME) written in C++ designed to be easy to use and integrate but yet fast and efficient."
> +AUTHOR = "Stefano Barbato <stefano at codesink.org>"
> +HOMEPAGE = "http://www.codesink.org/mimetic_mime_library.html"
> +BUGTRACKER = "https://github.com/LadislavSopko/mimetic/issues"
> +
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=b49da7df0ca479ef01ff7f2d799eabee"
> +
> +SRCREV = "50486af99b4f9b35522d7b3de40b6ce107505279"
> +SRC_URI += "git://github.com/LadislavSopko/mimetic/ \
> +            file://0001-libmimetic-Removing-test-directory-from-the-Makefile.patch \
> +           "
> +
> +S = "${WORKDIR}/git"
> +
> +CXXFLAGS += "-Wno-narrowing"
> +
> +inherit autotools
> --
> 2.23.0
>