[oe] [meta-oe][PATCH] meta-oe: master: remmina - use PACKAGECONFIG for spice

Jan-Simon Moeller dl9pf at gmx.de
Wed Feb 19 11:51:26 UTC 2020


remmina depends on spice and spice-protocol but they are in meta-networking.
Use the PACKAGECONFIG flag to avoid hardcoding the dependency.

Signed-off-by: Jan-Simon Moeller <dl9pf at gmx.de>
---
 meta-oe/recipes-support/remmina/remmina_1.3.6.bb | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/meta-oe/recipes-support/remmina/remmina_1.3.6.bb b/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
index f9963ff65..f9860a11f 100644
--- a/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
+++ b/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
@@ -5,8 +5,6 @@ LICENSE = "GPLv2 & openssl"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=dab7215512044d49037272ce1ac4ea8f file://LICENSE.OpenSSL;md5=c1eb3cee0a4dea27503c531267a69769"
 DEPENDS += "openssl freerdp gtk+3 gdk-pixbuf atk libgcrypt avahi-ui libsodium libssh vte json-glib libsoup-2.4 libvncserver libsecret"

-DEPENDS_append_x86 = " spice spice-protocol"
-DEPENDS_append_x86-64 = " spice spice-protocol"

 DEPENDS_append_libc-musl = " libexecinfo"
 LDFLAGS_append_libc-musl = " -lexecinfo"
@@ -23,11 +21,7 @@ inherit cmake features_check mime-xdg
 # depends on avahi-ui with this restriction
 ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"

-EXTRA_OECMAKE += "-DWITH_APPINDICATOR=OFF -DWITH_GETTEXT=OFF -DWITH_TRANSLATIONS=OFF -DWITH_SPICE=OFF"
-
-EXTRA_OECMAKE_append_x86 = " -DWITH_SPICE=ON"
-EXTRA_OECMAKE_append_x86-64 = " -DWITH_SPICE=ON"
-
+EXTRA_OECMAKE += "-DWITH_APPINDICATOR=OFF -DWITH_GETTEXT=OFF -DWITH_TRANSLATIONS=OFF"

 do_install_append(){
     # We dont need the extra stuff form other desktop environments
@@ -36,6 +30,8 @@ do_install_append(){
     rm -rf ${D}/${datadir}/gnome-session
 }

+PACKAGECONFIG[spice] = "-DWITH_SPICE=ON, -DWITH_SPICE=OFF, spice spice-protocol"
+
 RDEPENDS_${PN} = "bash"

 FILES_${PN}_append = " ${datadir}/icons/hicolor/*"
--
2.11.0



More information about the Openembedded-devel mailing list