[oe] [meta-networking][PATCH 2/2] quagga: install tmpfiles snippet to /usr/lib/tmpfiles.d

[Dan Callaghan]

Excerpts from Khem Raj's message of 2020-02-11 16:44:45 -08:00:
> On 2/10/20 10:08 PM, Dan Callaghan wrote:
> > Package-owned tmpfiles snippets belong in /usr/lib/tmpfiles.d,
> > /etc/tmpfiles.d is for administrator customisations.
> >
> > Signed-off-by: Dan Callaghan <dan.callaghan at opengear.com>
> > ---
> >   meta-networking/recipes-protocols/quagga/quagga.inc | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-networking/recipes-protocols/quagga/quagga.inc b/meta-networking/recipes-protocols/quagga/quagga.inc
> > index 2673a8976..f35b27160 100644
> > --- a/meta-networking/recipes-protocols/quagga/quagga.inc
> > +++ b/meta-networking/recipes-protocols/quagga/quagga.inc
> > @@ -116,9 +116,9 @@ do_install () {
> >       done
> >
> >       if ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'true', 'false', d)}; then
> > -        install -d ${D}${sysconfdir}/tmpfiles.d
> > +        install -d ${D}${nonarch_libdir}/tmpfiles.d
> >           echo "d /run/quagga 0755 quagga quagga -" \
> > -        > ${D}${sysconfdir}/tmpfiles.d/${BPN}.conf
> > +        > ${D}${nonarch_libdir}/tmpfiles.d/${BPN}.conf
> >       fi
> >
> >       # Remove sysinit script if sysvinit is not in DISTRO_FEATURES
> >
> 
> Fails packaging
> 
> ERROR: QA Issue: quagga: Files/directories were installed but not
> shipped in any package:
>    /usr/lib/tmpfiles.d
>    /usr/lib/tmpfiles.d/quagga.conf
> 
> 
> http://errors.yoctoproject.org/Errors/Details/390597/

Oops. I will send an updated patch.

I wonder if OE-Core should have a directory variable similar to 
${systemd_system_unitdir}, say ${systemd_tmpfilesdir}, and put it in the 
global FILES list? Right now the recipes in meta-oe use a mixture of
${sysconfdir}/tmpfiles.d and ${libdir}/tmpfiles.d...

On second thought I am not quite sure if it should be ${nonarch_libdir} 
or ${libdir}. I can't see anywhere that the systemd recipe explicitly 
configures that directory at build time, but in our product
systemd-tmpfiles winds up looking in /usr/lib/tmpfiles.d which I assumed 
was ${nonarch_libdir}/tmpfiles.d.

-- 
Dan Callaghan <dan.callaghan at opengear.com>
Software Engineer
Opengear <https://opengear.com/>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20200219/2306582d/attachment.sig>