[oe] [meta-oe][PATCH 1/2] nodejs: don't enable ares support by default

[Martin Jansa]

On Tue, Feb 25, 2020 at 08:22:02PM +0100, Martin Jansa wrote:
> On Tue, Feb 25, 2020 at 11:13:42AM -0800, Khem Raj wrote:
> > On Tue, Feb 25, 2020 at 11:07 AM Martin Jansa <martin.jansa at gmail.com> wrote:
> > >
> > > * c-ares is in meta-networking and meta-oe doesn't depend on meta-networking
> > > * fixes:
> > >   ERROR: Nothing PROVIDES 'c-ares' (but meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb DEPENDS on or otherwise requires it)
> > >   in builds without meta-networking
> > >
> > 
> > this patch makes me thing if c-ares is better suites for meta-networking
> 
> ?
> 
> This patch exists, because c-ares _is_ in meta-networking, while nodejs
> which depends on it is in meta-oe.

It got enabled in default PACKAGECONFIG in:

commit 76dd3dac1f1e67a5c44ad732b8e827cc36ded641
Author: André Draszik <git at andred.net>
Date:   Tue Oct 29 16:42:24 2019 +0000

    nodejs: allow use of system c-ares (and make default)
    
    Use system c-ares via PACKAGECONFIG by default. So far,
    nodejs had been built using its embedded copy of c-ares,
    which we generally try to avoid, for the known reasons
    (independent updates, cve & license checks, etc).
    
    Notes:
    * otherwise nodejs uses its bundled version of c-ares
    * the PACKAGECONFIG variable is 'ares' so as to be in
      line with other uses of this (wget & curl recipes in
      OE core)
    
    Signed-off-by: André Draszik <git at andred.net>
    Signed-off-by: Khem Raj <raj.khem at gmail.com>

So unless you actually meant to move c-ares from meta-networking to
meta-oe..

> > > Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> > > ---
> > >  meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb b/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
> > > index 6eb52c209a..9f91a3f4dd 100644
> > > --- a/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
> > > +++ b/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
> > > @@ -51,7 +51,7 @@ ARCHFLAGS_arm = "${@bb.utils.contains('TUNE_FEATURES', 'callconvention-hard', '-
> > >  GYP_DEFINES_append_mipsel = " mips_arch_variant='r1' "
> > >  ARCHFLAGS ?= ""
> > >
> > > -PACKAGECONFIG ??= "ares icu libuv zlib"
> > > +PACKAGECONFIG ??= "icu libuv zlib"
> > >  PACKAGECONFIG[ares] = "--shared-cares,,c-ares"
> > >  PACKAGECONFIG[gyp] = ",,gyp-py2-native"
> > >  PACKAGECONFIG[icu] = "--with-intl=system-icu,--without-intl,icu"
> > > --
> > > 2.20.1
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel at lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20200225/1e88035e/attachment.sig>