[oe] [PATCH] rocksdb: Fix compile error for DEBUG_BUILD

Khem Raj raj.khem at gmail.com
Thu Jan 9 07:23:18 UTC 2020


On Wed, Jan 8, 2020 at 11:15 PM Robert Yang <liezhi.yang at windriver.com> wrote:
>
>
>
> On 1/8/20 5:27 PM, Adrian Bunk wrote:
> > On Wed, Jan 08, 2020 at 02:09:03PM +0800, Robert Yang wrote:
> >> Fixed do_compile error when DEBUG_BUILD = "1":
> >> db/write_thread.cc:183:14: error: 'state' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> >> ...
> >
> > -Og warnings are not 100% reliable, and in general -Werror is
> > problematic for distributions.
> >
> > Does building with -DFAIL_ON_WARNINGS=OFF fix this problem?
>

I think this should be used when we have warnings which we have no
easy control over
and no good fixes.

> Yes, it works.
>
> I think that the correct way to fix it is initialize it rather than ignore the
> error.

Thats fine, Also submit this patch to rocksdb upstream as well.

>
> // Robert
>
> >
> > cu
> > Adrian
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


More information about the Openembedded-devel mailing list