[oe] [meta-java][PATCH] java.bbclass: oe_makeclasspath does nothing without -s

Richard Leitner richard.leitner at skidata.com
Tue Jan 21 08:57:49 UTC 2020


On Tue, Jan 21, 2020 at 08:46:29AM +0000, André Draszik wrote:
> On Tue, 2020-01-21 at 07:44 +0100, Richard Leitner wrote:
> > Hi,
> > this is a note to let you know that I've just added this patch to the
> > master-next branch of the meta-java repository at
> >      git://git.yoctoproject.org/meta-java
> > 
> > As soon as it has gone through some more testing it will likely be
> > merged to the master branch.
> > 
> > If you have any questions, please let me know.
> > 
> > regards;Richard.L
> > 
> > On Mon, Jan 20, 2020 at 08:28:31PM +0000, Davis, Michael wrote:
> > > oe_makeclasspath is supposed to output for the target platform by default and the staging platform with -s.
> > > However it checks if the file exists even if -s is not defined which is always false.
> > > Additionaly remove comment around an error that never occurs.
> > > 
> > > Signed-off-by: Michael Davis <michael.davis at essvote.com>
> > > ---

...

> > > @@ -113,9 +113,9 @@ oe_makeclasspath() {
> > >            *)
> > >                file=$dir/$1.jar
> > >  
> > > -              if [ -e $file ]; then
> > > -                  classpath=$classpath$delimiter$file
> > > -                  delimiter=":"
> > > +              if [ $staging == false ] || [ -e $file ]; then
>                                  ^^
> Can you please remove this bashism. One '=' is enough.

Sure. Thanks for the catch.
I'll push an update to master-next in the next minutes.

> 
> Cheers,
> Andre'

regards;rl


More information about the Openembedded-devel mailing list