[oe] [meta-java][PATCH 3/4] openjre-8: fix debuginfo fixup in do_install

[Richard Leitner]

On Mon, Jan 27, 2020 at 11:37:51AM +0000, André Draszik wrote:
> Hi,
> 
> On Mon, 2020-01-27 at 12:24 +0100, Richard Leitner wrote:
> > Based on a patch sent by Jacob Kroon.
> > 
> > Signed-off-by: Richard Leitner <richard.leitner at skidata.com>
> > Cc: Jacob Kroon <jacob.kroon at gmail.com>
> > ---
> >  recipes-core/openjdk/openjre-8_242.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/recipes-core/openjdk/openjre-8_242.bb b/recipes-core/openjdk/openjre-8_242.bb
> > index 4ed2e6b..2c8a6a5 100644
> > --- a/recipes-core/openjdk/openjre-8_242.bb
> > +++ b/recipes-core/openjdk/openjre-8_242.bb
> > @@ -11,7 +11,7 @@ do_install() {
> >      cp -rp ${B}/images/j2re-image/* ${D}${JRE_HOME}
> >      chown -R root:root ${D}${JRE_HOME}
> >      install -m644 ${WORKDIR}/jvm.cfg  ${D}${JRE_HOME}/lib/${JDK_ARCH}/
> > -    find ${D}${JDK_HOME} -name "*.debuginfo" -exec rm {} \;
> > +    [ -d ${D}${JDK_HOME} ] && find ${D}${JDK_HOME} -name "*.debuginfo" -exec rm {} \;
> 
> Does this line make sense? The JRE build should not produce any files in the JDK_HOME
> directory, I think?

True ;-)

> 
> So the only 'fix' this is doing is to silence 'find' to not print a warning about a
> directory it can't find?
> 
> Shouldn't the line be dropped completely instead?
> 
> Should we worry if the JRE build (sometimes?) places files into JDK_HOME?

Good catch. Thanks.
It seems this was a copy'n'paste error from my side intially.
Furthermore openjre doesn't create any debuginfo files, therefore I'll
modify this patch.

Thanks again.

regards;rl

> 
> 
> A.
> 
> >  }
> >  
> >  FILES_${PN}_append = "\
> > -- 
> > 2.24.1
> > 
>