[oe] [meta-networking][PATCH] meta-networking: s|${COREBASE}/meta/files/common-licenses|${COMMON_LICENSE_DIR}

[Peter Kjellerstedt]

> -----Original Message-----
> From: André Draszik <git at andred.net>
> Sent: den 29 februari 2020 08:08
> To: Peter Kjellerstedt <peter.kjellerstedt at axis.com>; openembedded-
> devel at lists.openembedded.org
> Subject: Re: [oe] [meta-networking][PATCH] meta-networking:
> s|${COREBASE}/meta/files/common-licenses|${COMMON_LICENSE_DIR}
> 
> On Fri, 2020-02-28 at 19:55 +0000, Peter Kjellerstedt wrote:
> > > -----Original Message-----
> > > From: openembedded-devel-bounces at lists.openembedded.org <openembedded-
> devel-bounces at lists.openembedded.org> On
> > > Behalf Of André Draszik
> > > Sent: den 27 februari 2020 17:42
> > > To: openembedded-devel at lists.openembedded.org
> > > Subject: [oe] [meta-networking][PATCH] meta-networking:
> s|${COREBASE}/meta/files/common-
> > > licenses|${COMMON_LICENSE_DIR}
> > >
> > > Signed-off-by: André Draszik <git at andred.net>
> > > ---
> > >  meta-networking/recipes-connectivity/samba/samba_4.10.13.bb | 4 ++--
> > >  meta-networking/recipes-daemons/lldpd/lldpd_1.0.4.bb        | 2 +-
> > >  meta-networking/recipes-support/arptables/arptables_git.bb  | 2 +-
> > >  meta-networking/recipes-support/ncp/ncp_1.2.4.bb            | 2 +-
> > >  4 files changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/meta-networking/recipes-
> connectivity/samba/samba_4.10.13.bb b/meta-networking/recipes-
> > > connectivity/samba/samba_4.10.13.bb
> > > index 71d8fa2f8..4d57255f1 100644
> > > --- a/meta-networking/recipes-connectivity/samba/samba_4.10.13.bb
> > > +++ b/meta-networking/recipes-connectivity/samba/samba_4.10.13.bb
> > > @@ -3,8 +3,8 @@ SECTION = "console/network"
> > >
> > >  LICENSE = "GPL-3.0+ & LGPL-3.0+ & GPL-2.0+"
> > >  LIC_FILES_CHKSUM =
> "file://COPYING;md5=d32239bcb673463ab874e80d47fae504 \
> > > -                    file://${COREBASE}/meta/files/common-
> licenses/LGPL-3.0;md5=bfccfe952269fff2b407dd11f2f3083b \
> > > -                    file://${COREBASE}/meta/files/common-
> licenses/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6 "
> > > +                    file://${COMMON_LICENSE_DIR}/LGPL-
> 3.0;md5=bfccfe952269fff2b407dd11f2f3083b \
> > > +                    file://${COMMON_LICENSE_DIR}/GPL-
> 2.0;md5=801f80980d171dd6425610833a22dbe6 "
> >
> > These two are pointless since there is a provided COPYING file.
> > Just remove them.
> >
> > >  SAMBA_MIRROR = "http://samba.org/samba/ftp"
> > >  MIRRORS += "\
> > > diff --git a/meta-networking/recipes-daemons/lldpd/lldpd_1.0.4.bb
> b/meta-networking/recipes-
> > > daemons/lldpd/lldpd_1.0.4.bb
> > > index 8fdaf848f..21b02687f 100644
> > > --- a/meta-networking/recipes-daemons/lldpd/lldpd_1.0.4.bb
> > > +++ b/meta-networking/recipes-daemons/lldpd/lldpd_1.0.4.bb
> > > @@ -1,7 +1,7 @@
> > >  SUMMARY = "A 802.1ab implementation (LLDP) to help you locate
> neighbors of all your equipments"
> > >  SECTION = "net/misc"
> > >  LICENSE = "ISC"
> > > -LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-
> licenses/ISC;md5=f3b90e78ea0cffb20bf5cca7947a896d"
> > > +LIC_FILES_CHKSUM =
> "file://${COMMON_LICENSE_DIR}/ISC;md5=f3b90e78ea0cffb20bf5cca7947a896d"
> >
> > There is a LICENSE file in the tar ball. Please use it instead.
> >
> > >  DEPENDS = "libbsd libevent"
> > >
> > > diff --git a/meta-networking/recipes-
> support/arptables/arptables_git.bb b/meta-networking/recipes-
> > > support/arptables/arptables_git.bb
> > > index cec1d1f77..e88631e08 100644
> > > --- a/meta-networking/recipes-support/arptables/arptables_git.bb
> > > +++ b/meta-networking/recipes-support/arptables/arptables_git.bb
> > > @@ -1,7 +1,7 @@
> > >  SUMMARY = "Administration tool for arp packet filtering"
> > >  SECTION = "net"
> > >  LICENSE = "GPL-2.0"
> > > -LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-
> licenses/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6"
> > > +LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/GPL-
> 2.0;md5=801f80980d171dd6425610833a22dbe6"
> >
> > There is a COPYING file in the Git repository. Please use it instead.
> >
> > >  SRCREV = "f4ab8f63f11a72f14687a6646d04ae1bae3fa45f"
> > >  PV = "0.0.4+git${SRCPV}"
> > >
> > > diff --git a/meta-networking/recipes-support/ncp/ncp_1.2.4.bb b/meta-
> networking/recipes-support/ncp/ncp_1.2.4.bb
> > > index f42223b1f..ba6e23e86 100644
> > > --- a/meta-networking/recipes-support/ncp/ncp_1.2.4.bb
> > > +++ b/meta-networking/recipes-support/ncp/ncp_1.2.4.bb
> > > @@ -4,7 +4,7 @@ security or integrity checking, no throttling, no
> features, except \
> > >  one: you don't have to type the coordinates of your peer."
> > >  HOMEPAGE = "http://www.fefe.de/ncp"
> > >  LICENSE = "GPLv2"
> >
> > I can find no information about license either in the code or at
> > http://www.fefe.de/ncp. How do you know this license is correct?
> 
> Please see attached email.

Hmm, ok. I think it would be good if this was actually documented in 
the recipe itself then.

> Cheers,
> Andre'
> 
> >
> > > -LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-
> licenses/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6"
> > > +LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/GPL-
> 2.0;md5=801f80980d171dd6425610833a22dbe6"
> > >  DEPENDS = "libowfat"
> > >
> > >  SRC_URI = "https://dl.fefe.de/${BP}.tar.bz2"
> > > --
> > > 2.23.0.rc1
> > >
> > > --
> >
> > //Peter

//Peter