[oe-issues] [Bug 1873] SIMpad switches driver killes the irq of the ucb1x00 touchscreen driver (patch inside)

bugzilla-daemon at tinman.treke.net bugzilla-daemon at tinman.treke.net
Tue Feb 27 17:22:37 UTC 2007


http://bugs.openembedded.org/show_bug.cgi?id=1873





------- Comment #4 from freyther at inf.fu-berlin.de  2007-02-27 09:22 -------
Some thoughs on the patch itself: The function ucb1x00_dev_irq(int idx, void
*id) can be simplified a lot.

The code like this
switch(irq)
if case 1: then shift by 1
if case 2: then shift by 2
if case 3: then shift by 3

can be easily written
if not RANGE_IS_VALID return
else shift by irq and then lookup the keynumber in a table/array


-- 
Configure bugmail: http://bugs.openembedded.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.




More information about the Openembedded-issues mailing list