[Bug 3738] RFC: u-boot for zaurus c7x0 and akita

[bugzilla-daemon at amethyst.openembedded.net]

http://bugs.openembedded.net/show_bug.cgi?id=3738





--- Comment #34 from Thomas Kunze <thommycheck at gmx.de>  2008-08-15 20:52:24 ---
>+# ZAURUS SPECIFIC 
>+# defaults / if needed set it in local.conf
>+# corgi || shepherd  25M
>+# husky || boxer     53M
>+# akita              58M
>+CUSTOM_ROOTFS_SIZE_akita ?= "59392k"
>+CUSTOM_ROOTFS_SIZE_c7x0 ?= "54272k"

I think there should be ROOTFS_SIZE in the machine configs and they should be
used here.

>+
>+do_configure_prepend_akita() {
>+        sed -i s:CUSTOM_ROOTFS_SIZE:${CUSTOM_ROOTFS_SIZE_akita}:g ${S}/include/configs/akita.h
>+}
>+
>+do_configure_prepend_c7x0() {
>+        sed -i s:CUSTOM_ROOTFS_SIZE:${CUSTOM_ROOTFS_SIZE_c7x0}:g ${S}/include/configs/corgi.h
>+}

Here is an error: user only ${CUSTOM_ROOTFS_SIZE} its set to the right value by
using the overrides above.
The two nearly identical functions are ugly. IMO it would be nicer to change
the patches to read the information from a common file and add one
configure_prepend for all machines that does noting if ROOTFS_SIZE is empty.

-- 
Configure bugmail: http://bugs.openembedded.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.