[Bug 4520] [RFC] kexecboot: passing extra cmdline arguments

[bugzilla-daemon at amethyst.openembedded.net]

http://bugs.openembedded.net/show_bug.cgi?id=4520





--- Comment #8 from Yuri Bushmelev <jay4mail at gmail.com>  2008-08-29 13:47:02 ---
(In reply to comment #7)
> >+-	char command[COMMAND_LINE_SIZE + 60];
> >++	char command[COMMAND_LINE_SIZE];
> 
> Why this change? the command could be bigger than COMMAND_LINE_SIZE.

Yeah.. It was my mistake. I've decide that COMMAND_LINE_SIZE is whole size of
kexec's parameters. BTW, there is 64 extra bytes in longest string
(/usr/sbin/kexec --command-line=" root= rootfstype= rootwait" -l). Here is the
reason why I don't like hardcoded numbers. I'll consider to rewrite code at
this point..

> Patch still doesn't apply (fresh mtn checkout). Maybe you edited the patch?
> Please try with fresh checkout.

I'll try on my checkout today.

-- 
Configure bugmail: http://bugs.openembedded.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.