[bitbake-devel] bitbake/logging: Overhaul internal logging process

Chris Larson clarson at kergoth.com
Fri Aug 12 14:35:37 UTC 2011


On Fri, Aug 12, 2011 at 7:25 AM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> -def set_debug_level(level):
> -    for log in loggers.itervalues():
> -        log.setLevel(logging.NOTSET)
> +loggerDefaults = [0, False, []]

This line is meaningless at first glance. It's impossible to tell what
these values are intended to mean without finding its usages. Have you
considered using a different container than a list for this, or just
using separate variables?
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics




More information about the bitbake-devel mailing list