[bitbake-devel] bitbake/logging: Overhaul internal logging process

Richard Purdie richard.purdie at linuxfoundation.org
Fri Aug 12 15:44:53 UTC 2011


On Fri, 2011-08-12 at 07:35 -0700, Chris Larson wrote:
> On Fri, Aug 12, 2011 at 7:25 AM, Richard Purdie
> <richard.purdie at linuxfoundation.org> wrote:
> > -def set_debug_level(level):
> > -    for log in loggers.itervalues():
> > -        log.setLevel(logging.NOTSET)
> > +loggerDefaults = [0, False, []]
> 
> This line is meaningless at first glance. It's impossible to tell what
> these values are intended to mean without finding its usages. Have you
> considered using a different container than a list for this, or just
> using separate variables?

Yes, I'd meant to do something about that but didn't get back around to
it.

Cheers,

Richard






More information about the bitbake-devel mailing list