[bitbake-devel] [PATCH] bb.utils.which is intend to locate regular file only as it is written in comment

[Christopher Larson]

On Tue, Jul 8, 2014 at 8:09 AM, Vitaliy Kharin <kvserr at gmail.com> wrote:

> Signed-off-by: Vitaliy Kharin <vitaliy.kharin at lge.com>
> ---
>  bitbake/lib/bb/utils.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bitbake/lib/bb/utils.py b/bitbake/lib/bb/utils.py
> index 0be45e1..c48b237 100644
> --- a/bitbake/lib/bb/utils.py
> +++ b/bitbake/lib/bb/utils.py
> @@ -809,7 +809,7 @@ def which(path, item, direction = 0, history = False):
>      for p in paths:
>          next = os.path.join(p, item)
>          hist.append(next)
> -        if os.path.exists(next):
> +        if os.path.isfile(next):
>              if not os.path.isabs(next):
>                  next = os.path.abspath(next)
>              if history:
>

This seems questionable to me. With this, it wouldn't find symlinks, no?
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20140708/83decd0d/attachment-0002.html>