[bitbake-devel] [PATCH] bitbake: fetch2: Revalidate checksums, YOCTO #5571

[Clemens Lang]

Hi Martin,

On Fri, Mar 06, 2015 at 01:22:38PM +0100, Martin Jansa wrote:
> Using pickle is much better than counting the checksums on every
> do_fetch.. we have GBs of sources and we don't want to spend extra
> minutes on the build to re-check them if they are identical.

That's what I thought as well. The pickle method should scale a lot
better than re-running the hash calculation, especially in terms of I/O
ops.

> Maybe add the file time stamp as well, if the file was modified then
> .done could be invalidated and checksums re-verified.

I could modify the code to avoid reading the precomputed checksums if
the .done file is older than the downloaded file, which should cover
this case. Of course, the modification date will not be of much use if
the download is not a file, but a directory.

Does this sound good to you?


Clemens
-- 
BMW Car IT GmbH
Clemens Lang
Spezialist Entwicklung
Lise-Meitner-Straße 14
89081 Ulm

Tel: +49-731-37804182
Mail: clemens.lang at bmw-carit.de
Web: http://www.bmw-carit.de
--------------------------------------------------------------------
BMW Car IT GmbH
Geschäftsführer: Michael Würtenberger und Reinhard Stolle
Sitz und Registergericht: München HRB 134810
--------------------------------------------------------------------