[bitbake-devel] [PATCH] bitbake: fetch2: Revalidate checksums, YOCTO #5571

[Martin Jansa]

On Fri, Mar 06, 2015 at 02:03:20PM +0100, Clemens Lang wrote:
> Hi Martin,
> 
> On Fri, Mar 06, 2015 at 01:22:38PM +0100, Martin Jansa wrote:
> > Using pickle is much better than counting the checksums on every
> > do_fetch.. we have GBs of sources and we don't want to spend extra
> > minutes on the build to re-check them if they are identical.
> 
> That's what I thought as well. The pickle method should scale a lot
> better than re-running the hash calculation, especially in terms of I/O
> ops.
> 
> > Maybe add the file time stamp as well, if the file was modified then
> > .done could be invalidated and checksums re-verified.
> 
> I could modify the code to avoid reading the precomputed checksums if
> the .done file is older than the downloaded file, which should cover
> this case. Of course, the modification date will not be of much use if
> the download is not a file, but a directory.
> 
> Does this sound good to you?

yes :)

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20150306/60d83f79/attachment-0002.sig>