[bitbake-devel] [PATCH] Fix bug 8940 - Alow Hob to run images on a custom simulator, other than qemu

[Joshua G Lock]

Hi Mirela,

On Sun, 2016-02-14 at 22:09 +0000, Mirela Rabulea wrote:
> Hi Joshua,
> I found one more issue with a corner case when commuting from "Run
> custom image" to "Deploy image". From the comments I found in the
> code, the case when there are both "runnable" and "deployable"
> present in the same build is not expected.
> However, with the introduction of the "Run custom", I think this
> requires a fix, so here is the v4 of the patch (squashed version
> attached).
> If you did not get to check the v3 patch, you may skip it and check
> the v4.

This version seems to work much better, thanks.

I've had another look over the patch and it looks OK to me. The only
thing which seems a little strange is that in several parts of the
patch you're accessing and setting a self.is_runnable property but at
Ln 217, Ln 220 & Ln 237 in ImageDetailsPage you're using a local
variable called is_runnable — is that correct/intended?

Thanks for your work on this,

Joshua