[bitbake-devel] [PATCH] Fix bug 8940 - Alow Hob to run images on a custom simulator, other than qemu

[Mirela Rabulea]

Hi Joshua,

> -----Original Message-----
> From: Joshua G Lock [mailto:joshua.g.lock at linux.intel.com]
> Sent: Tuesday, February 16, 2016 6:07 PM

> 
> This version seems to work much better, thanks.
> 
> I've had another look over the patch and it looks OK to me. The only thing
> which seems a little strange is that in several parts of the patch you're
> accessing and setting a self.is_runnable property but at Ln 217, Ln 220 & Ln
> 237 in ImageDetailsPage you're using a local variable called is_runnable — is
> that correct/intended?
> 

The local variable "is_runnable" was used in create_bottom_buttons(), I did not change this. I just saved the return value of create_bottom_buttons() in self.is_runnable property, instead of another local, so that I can use the property later, like in run_button_clicked_cb(). This was my intention.

Thanks,
Mirela