[bitbake-devel] [PATCH] bb/fetch2: fixes copying of file://dir; subdir=foo, bug 6128 and bug 6129

[Sasha Shashkevich]

>>>>> NOTE: Unpacking /home/pokybuild/yocto-autobuilder/yocto
>>>>> -worker/nightly-x86-64/build/scripts/runqemu to
>>>>> /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-x86
>>>>> -64/build/build/tmp/work/i686-nativesdk-pokysdk-linux/nativesdk
>>>>> -qemu-helper/1.0-r9/
>>>>> cp: `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-x86
>>>>> -64/build/scripts/runqemu' and `/home/pokybuild/yocto
>>>>> -autobuilder/yocto-worker/nightly-x86-64/build/scripts/runqemu'
>>>>> are the same file
>>>>> DEBUG: Python function base_do_unpack finished
>>>>> DEBUG: Python function do_unpack finished
>>> 
>>> 
>>> Despite all tests were successfully passed, something remains
>>> incorrect. Very sensitive feature. I'll check what is wrong and
>>> supply additional test cases with updated patch. Seems I need to
>>> build several configurations locally before submitting such patches
>>> –
>>> just tests are not enough.
>> 
>> Yes, sadly our tests aren't entirely complete. I'd much appreciate
>> added test cases if we can figure out what the issue is.
>> 
>> This change does introduce a change in behaviour, admittedly one
>> where
>> we think the current behaviour is incorrect. It is possible recipes
>> are
>> relying on that incorrect behaviour though and they may need
>> adjusting.
> 
> FWIW, a:
> 
> -                if urldata.type == "file":
> +                if urldata.type == "file" and not urldata.path.startswith("/"):
> 
> did seem to fix the failing recipe which was doing something valid. What 
> effect elsewhere this has I haven't checked.
> 

Yep, that's the reason: SRC_URI could contain absolute paths. Thank you for finding that. I'll check the rest of build and send patch #3.

Regards,
Alexander
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20160226/583eaf17/attachment-0002.html>