[bitbake-devel] [PATCH] bb/fetch2: fixes copying of file://dir; subdir=foo, bug 6128 and bug 6129

[Sasha Shashkevich]

>>>> Despite all tests were successfully passed, something remains
>>>> incorrect. Very sensitive feature. I'll check what is wrong and
>>>> supply additional test cases with updated patch. Seems I need to
>>>> build several configurations locally before submitting such patches
>>>> –
>>>> just tests are not enough.
>>> 
>>> Yes, sadly our tests aren't entirely complete. I'd much appreciate
>>> added test cases if we can figure out what the issue is.
>>> 
>>> This change does introduce a change in behaviour, admittedly one
>>> where
>>> we think the current behaviour is incorrect. It is possible recipes
>>> are
>>> relying on that incorrect behaviour though and they may need
>>> adjusting.
>> 
>> FWIW, a:
>> 
>> -                if urldata.type == "file":
>> +                if urldata.type == "file" and not urldata.path.startswith("/"):
>> 
>> did seem to fix the failing recipe which was doing something valid. What 
>> effect elsewhere this has I haven't checked.
>> 
> 
> Yep, that's the reason: SRC_URI could contain absolute paths. Thank you for finding that. I'll check the rest of build and send patch #3.

Some other recipes are still failing even with your suggestion. WIP. This isn't my high prio task in project, so it takes some time to fix all cases.

Regards,
Alexander

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20160227/df13cb59/attachment-0002.html>