[bitbake-devel] [PATCH] xmlrpc: fix bug in setting XMLRPCServer.single_use

[Joshua G Lock]

On Mon, 2016-03-07 at 21:21 +0200, Ed Bartosh wrote:
> On Fri, Mar 04, 2016 at 10:30:06AM +0000, Joshua G Lock wrote:
> > 
> > On Fri, 2016-03-04 at 10:13 +0200, Ed Bartosh wrote:
> > > 
> > > XMLRPCServer.single_use attribute was always set to False.
> > > This caused xmlrpc server to keep running after build is done as
> > > BitBakeServerCommands.removeClient only shuts down server if its
> > > single_use attribute is set to True.
> > > 
> > > Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
> > > ---
> > >  bitbake/lib/bb/server/xmlrpc.py | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/bitbake/lib/bb/server/xmlrpc.py
> > > b/bitbake/lib/bb/server/xmlrpc.py
> > > index 1ceca51..d627550 100644
> > > --- a/bitbake/lib/bb/server/xmlrpc.py
> > > +++ b/bitbake/lib/bb/server/xmlrpc.py
> > > @@ -193,6 +193,8 @@ class XMLRPCServer(SimpleXMLRPCServer,
> > > BaseImplServer):
> > >          BaseImplServer.__init__(self)
> > >          if (interface[1] == 0):     # anonymous port, not
> > > getting
> > > reused
> > >              self.single_use = True
> > > +        else:
> > > +            self.singe_use = False
> > This won't work, right? Typo.
> > 
> Why do you think so? It works for me so far :)

I don't know toaster's code and only have the context from this diff,
however it looks like you've removed a line that sets a single_use
variable and added a line that sets a singe_use variable. These are
different variables (looks like the result of a typo) thus I wouldn't
expect it to work, or at least I wouldn't expect the addition of this
line to have affected things.

(Just to be sure I used git grep on the bitbake repository and didn't
find any instances of singe_use).

Regards,

Joshua