[bitbake-devel] [PATCH] xmlrpc: fix bug in setting XMLRPCServer.single_use

[Martin Jansa]

On Mon, Mar 07, 2016 at 09:21:20PM +0200, Ed Bartosh wrote:
> On Fri, Mar 04, 2016 at 10:30:06AM +0000, Joshua G Lock wrote:
> > On Fri, 2016-03-04 at 10:13 +0200, Ed Bartosh wrote:
> > > XMLRPCServer.single_use attribute was always set to False.
> > > This caused xmlrpc server to keep running after build is done as
> > > BitBakeServerCommands.removeClient only shuts down server if its
> > > single_use attribute is set to True.
> > > 
> > > Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
> > > ---
> > >  bitbake/lib/bb/server/xmlrpc.py | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/bitbake/lib/bb/server/xmlrpc.py
> > > b/bitbake/lib/bb/server/xmlrpc.py
> > > index 1ceca51..d627550 100644
> > > --- a/bitbake/lib/bb/server/xmlrpc.py
> > > +++ b/bitbake/lib/bb/server/xmlrpc.py
> > > @@ -193,6 +193,8 @@ class XMLRPCServer(SimpleXMLRPCServer,
> > > BaseImplServer):
> > >          BaseImplServer.__init__(self)
> > >          if (interface[1] == 0):     # anonymous port, not getting
> > > reused
> > >              self.single_use = True
> > > +        else:
> > > +            self.singe_use = False
> > 
> > This won't work, right? Typo.
> >
> Why do you think so? It works for me so far :)

Then this change is useless, isn't it? Nothing is using singe_use
variable (with missing "l").

> 
> --
> Regards,
> Ed
> -- 
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20160308/5bf53d58/attachment-0002.sig>