[bitbake-devel] [PATCH] cookerdata: Fix log messages and ensure we exit

[Christopher Larson]

On Thu, May 12, 2016 at 2:56 AM, Richard Purdie <
richard.purdie at linuxfoundation.org> wrote:

> The string formatting wasn't correct and we should exit if we hit
> errors here similar to the other exception handlers.
>
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
>
> diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py
> index 50259a9..fba95af 100644
> --- a/lib/bb/cookerdata.py
> +++ b/lib/bb/cookerdata.py
> @@ -192,7 +192,8 @@ def catch_parse_error(func):
>                  fn, _, _, _ = traceback.extract_tb(tb, 1)[0]
>                  if not fn.startswith(bbdir):
>                      break
> -            parselog.critical("Unable to parse %s", fn,
> exc_info=(exc_class, exc, tb))
> +            parselog.critical("Unable to parse %s" % fn,
> exc_info=(exc_class, exc, tb))
> +            sys.exit(1)
>

The python logging module supports passing the % format values as
arguments, you don't have to format the string at call time. What was the
error here?
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20160512/2508d740/attachment.html>