[bitbake-devel] [PATCH] cookerdata: Fix log messages and ensure we exit

Richard Purdie richard.purdie at linuxfoundation.org
Thu May 12 09:56:59 UTC 2016


The string formatting wasn't correct and we should exit if we hit
errors here similar to the other exception handlers.

Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py
index 50259a9..fba95af 100644
--- a/lib/bb/cookerdata.py
+++ b/lib/bb/cookerdata.py
@@ -192,7 +192,8 @@ def catch_parse_error(func):
                 fn, _, _, _ = traceback.extract_tb(tb, 1)[0]
                 if not fn.startswith(bbdir):
                     break
-            parselog.critical("Unable to parse %s", fn, exc_info=(exc_class, exc, tb))
+            parselog.critical("Unable to parse %s" % fn, exc_info=(exc_class, exc, tb))
+            sys.exit(1)
         except bb.parse.ParseError as exc:
             parselog.critical(str(exc))
             sys.exit(1)




More information about the bitbake-devel mailing list