[bitbake-devel] [PATCH V2] fetch2/gitsm: fix config file concurrent update race

[Ming Liu]

Hi, Mark:

I could reproduce the error reported by Stefan, on the tip:
...
commit 8c8ecec2a722bc2885e2648d41ac8df07bdf660d
Author: Mark Hatle <mark.hatle at windriver.com>
Date:   Wed Jan 23 10:28:18 2019 -0500

    gitsmy.py: Fix unpack of submodules of submodules
...


seems GitSM does not handle recursive submodules.

in my aktualizr/1.0+gitAUTOINC+d00d1a04cc-7/git/.git/config:
...
[submodule "tests/tuf-test-vectors"]
        url =
/mnt/oe/downloads/git2/github.com.advancedtelematic.tuf-test-vectors.
[submodule "partial/extern/isotp-c"]
        url =
/mnt/oe/downloads/git2/github.com.advancedtelematic.isotp-c.git
[submodule "third_party/HdrHistogram_c"]
        url = /mnt/oe/downloads/git2/github.com.HdrHistogram.HdrHistogram_c
[submodule "third_party/googletest"]
        url = /mnt/oe/downloads/git2/github.com.google.googletest.git
...

in which, /mnt/oe/downloads/git2/github.com.advancedtelematic.isotp-c.git
has its own submodule,

aktualizr/1.0+gitAUTOINC+d00d1a04cc-7/git/partial/extern/isotp-c/.gitmodules
...
[submodule "deps/bitfield-c"]
        path = deps/bitfield-c
        url = https://github.com/advancedtelematic/bitfield-c.git
...

but that recursive submodule is fetched but not unpacked.

the best,
thank you

Patrick Vacek <patrickvacek at gmail.com> 於 2019年1月26日 週六 下午1:07寫道：

> On Sat, Jan 26, 2019 at 11:15 AM Stefan Agner <stefan at agner.ch> wrote:
>
>> > So it seems to be that something in the recipe was expecting semi-broken
>> > behavior.. and its actually a recipe problem.
>>
>> Agreed, in this case we need to fix the recipe.
>>
> Sorry, I must be missing something. What might be wrong with the recipe?
> Is there more that needs to be specified than a SRCREV and a branch? As far
> as I understand git, it keeps track of the submodules, so I don't know what
> other information there would be to provide. The reason this particular
> case is difficult is because there are recursive submodules. When we build
> aktualizr, we have to be careful to specify that. See
> https://github.com/advancedtelematic/aktualizr#building:
>
> git submodule update --init --recursive
>
> Thanks,
> Patrick
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/bitbake-devel/attachments/20190126/80261700/attachment.html>