[bitbake-devel] [PATCH V2] fetch2/gitsm: fix config file concurrent update race

[Richard Purdie]

On Sat, 2019-01-26 at 13:07 +0100, Patrick Vacek wrote:
> On Sat, Jan 26, 2019 at 11:15 AM Stefan Agner <stefan at agner.ch>
> wrote:
> > > So it seems to be that something in the recipe was expecting
> > semi-broken
> > > behavior.. and its actually a recipe problem.
> > 
> > Agreed, in this case we need to fix the recipe.
> 
> Sorry, I must be missing something. What might be wrong with the
> recipe? Is there more that needs to be specified than a SRCREV and a
> branch? As far as I understand git, it keeps track of the submodules,
> so I don't know what other information there would be to provide. The
> reason this particular case is difficult is because there are
> recursive submodules. When we build aktualizr, we have to be careful
> to specify that. See 
> https://github.com/advancedtelematic/aktualizr#building:
> 
> git submodule update --init --recursive

The problem is the checkout from the old version of the fetcher was
broken, it incorrectly checked out that SRCREV. The recipe was written
to build that broken checkout.

We've fixed the fetcher and Mark is saying that it now checks out the
correct thing (as compared with a git checkout outside of the build
system, independent of the fetcher).

The recipe assumed the old broken code so now fails to build. The
recipe therefore needs to change to adapt to the now correct source
code.

Cheers,

Richard