[oe-commits] [Bug 5335] Initial support for the Samsung Omnia (SGH-i900)

[bugzilla-daemon at git.openembedded.org]

http://bugs.openembedded.org/show_bug.cgi?id=5335


Stefan Schmidt <stefan at datenfreihafen.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stefan at datenfreihafen.org




--- Comment #4 from Stefan Schmidt <stefan at datenfreihafen.org>  2009-11-18 20:10:23 ---
Thanks for the rework. Some more comments, but you are on the right way. :)

- You made a git diff > foo.patch patch. While that will apply fine it misses a
patch description and your authorship. Best is to commit it to your repo
locally and then use git-format-patch to produce a patch from the commit.

- Please split this in several logical patches. A commit that adds a new
machine but also touches another recipe is hard to spot problems on later. I
would suggest the following split:
  - New machine file
  - Symlink in marvel firmware
  - Kernel recipe + defconfig + kernel patches
  - pointercal and tslib skript

- The PR = 0 can be dropped from the kernel recipe

- Instead of autorev we need a working rev for the recipe. Please add it to
conf/distro/include/sane-srcrevs.inc (You can still use autorevin your
local.conf of course, but having a known good rev in OE is a good idea)

That's all I spotted. Once these things are fixed I'm happily apply the
patches.

-- 
Configure bugmail: http://bugs.openembedded.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.